From cd0786c73e536a1d2507d77ce49e2ae2b8ee71a1 Mon Sep 17 00:00:00 2001 From: Stephan Gerhold Date: Tue, 14 Mar 2023 11:15:05 +0100 Subject: fix(bl32): always include arm_arch_svc in SP_MIN The PSCI_FEATURES call implementation in TF-A always indicates support for SMCCC_VERSION, but only BL31 ensures that the corresponding Arm Architecture Service (arm_arch_svc) is really included in the build. For SP_MIN only stm32mp1 currently includes it in the platform-specific make file. This means that it is easily possible to build configurations that violate the PSCI/SMCCC specification. On Linux this leads to incorrect detection of the SMC Calling Convention when using SP_MIN: [ 0.000000] psci: SMC Calling Convention v65535.65535 Fix this by always including the Arm Architecture Service in SP_MIN builds. This allows Linux to detect the convention correctly: [ 0.000000] psci: SMC Calling Convention v1.4 Change-Id: Iaa3076c162b7a55633ec1e27eb5c44d22f8eb2a1 Signed-off-by: Stephan Gerhold --- bl32/sp_min/sp_min.mk | 1 + 1 file changed, 1 insertion(+) (limited to 'bl32') diff --git a/bl32/sp_min/sp_min.mk b/bl32/sp_min/sp_min.mk index 0b7bc5763..065468c58 100644 --- a/bl32/sp_min/sp_min.mk +++ b/bl32/sp_min/sp_min.mk @@ -17,6 +17,7 @@ BL32_SOURCES += bl32/sp_min/sp_min_main.c \ bl32/sp_min/aarch32/entrypoint.S \ common/runtime_svc.c \ plat/common/aarch32/plat_sp_min_common.c\ + services/arm_arch_svc/arm_arch_svc_setup.c \ services/std_svc/std_svc_setup.c \ ${PSCI_LIB_SOURCES} -- cgit v1.2.3