diff options
author | Andrew Davis <afd@ti.com> | 2023-06-26 12:50:44 -0500 |
---|---|---|
committer | Andrew Davis <afd@ti.com> | 2023-10-27 10:26:50 -0500 |
commit | ce1008fef1ace613bc36886fd1627164edfef245 (patch) | |
tree | eae771e62d056438676f3a2fd55c1aaead0ed12e | |
parent | 7ab782801f8c78ae6a8293d25cad687c86a4ac4e (diff) |
feat(ti): query firmware for suspend capability
Instead of hardcoding this at build time we can ask the firmware if
suspend is supported and if not disable accordingly. Then remove compile-
time ifdefs.
Signed-off-by: Andrew Davis <afd@ti.com>
Change-Id: Ib966c04c0bdb79a82e8d890cec5e65d883acd6e3
-rw-r--r-- | plat/ti/k3/common/k3_gicv3.c | 4 | ||||
-rw-r--r-- | plat/ti/k3/common/k3_psci.c | 25 | ||||
-rw-r--r-- | plat/ti/k3/common/plat_common.mk | 4 |
3 files changed, 20 insertions, 13 deletions
diff --git a/plat/ti/k3/common/k3_gicv3.c b/plat/ti/k3/common/k3_gicv3.c index 019982261..eda943033 100644 --- a/plat/ti/k3/common/k3_gicv3.c +++ b/plat/ti/k3/common/k3_gicv3.c @@ -19,10 +19,8 @@ /* The GICv3 driver only needs to be initialized in EL3 */ uintptr_t rdistif_base_addrs[PLATFORM_CORE_COUNT]; -#if K3_PM_SYSTEM_SUSPEND static gicv3_redist_ctx_t rdist_ctx[PLATFORM_CORE_COUNT]; static gicv3_dist_ctx_t dist_ctx; -#endif static const interrupt_prop_t k3_interrupt_props[] = { PLAT_ARM_G1S_IRQ_PROPS(INTR_GROUP1S), @@ -94,7 +92,6 @@ void k3_gic_pcpu_init(void) gicv3_rdistif_init(plat_my_core_pos()); } -#if K3_PM_SYSTEM_SUSPEND void k3_gic_save_context(void) { for (unsigned int i = 0U; i < PLATFORM_CORE_COUNT; i++) { @@ -110,4 +107,3 @@ void k3_gic_restore_context(void) gicv3_rdistif_init_restore(i, &rdist_ctx[i]); } } -#endif diff --git a/plat/ti/k3/common/k3_psci.c b/plat/ti/k3/common/k3_psci.c index d84649567..e8d73dbd5 100644 --- a/plat/ti/k3/common/k3_psci.c +++ b/plat/ti/k3/common/k3_psci.c @@ -234,7 +234,6 @@ static int k3_validate_power_state(unsigned int power_state, return PSCI_E_SUCCESS; } -#if K3_PM_SYSTEM_SUSPEND static void k3_pwr_domain_suspend(const psci_power_state_t *target_state) { unsigned int core, proc_id; @@ -266,18 +265,15 @@ static void k3_get_sys_suspend_power_state(psci_power_state_t *req_state) req_state->pwr_domain_state[i] = PLAT_MAX_OFF_STATE; } } -#endif -static const plat_psci_ops_t k3_plat_psci_ops = { +static plat_psci_ops_t k3_plat_psci_ops = { .cpu_standby = k3_cpu_standby, .pwr_domain_on = k3_pwr_domain_on, .pwr_domain_off = k3_pwr_domain_off, .pwr_domain_on_finish = k3_pwr_domain_on_finish, -#if K3_PM_SYSTEM_SUSPEND .pwr_domain_suspend = k3_pwr_domain_suspend, .pwr_domain_suspend_finish = k3_pwr_domain_suspend_finish, .get_sys_suspend_power_state = k3_get_sys_suspend_power_state, -#endif .system_off = k3_system_off, .system_reset = k3_system_reset, .validate_power_state = k3_validate_power_state, @@ -286,8 +282,27 @@ static const plat_psci_ops_t k3_plat_psci_ops = { int plat_setup_psci_ops(uintptr_t sec_entrypoint, const plat_psci_ops_t **psci_ops) { + uint64_t fw_caps = 0; + int ret; + k3_sec_entrypoint = sec_entrypoint; + ret = ti_sci_query_fw_caps(&fw_caps); + if (ret) { + ERROR("Unable to query firmware capabilities (%d)\n", ret); + } + + /* If firmware does not support any known suspend mode */ + if (!(fw_caps & (MSG_FLAG_CAPS_LPM_DEEP_SLEEP | + MSG_FLAG_CAPS_LPM_MCU_ONLY | + MSG_FLAG_CAPS_LPM_STANDBY | + MSG_FLAG_CAPS_LPM_PARTIAL_IO))) { + /* Disable PSCI suspend support */ + k3_plat_psci_ops.pwr_domain_suspend = NULL; + k3_plat_psci_ops.pwr_domain_suspend_finish = NULL; + k3_plat_psci_ops.get_sys_suspend_power_state = NULL; + } + *psci_ops = &k3_plat_psci_ops; return 0; diff --git a/plat/ti/k3/common/plat_common.mk b/plat/ti/k3/common/plat_common.mk index fb633a832..23efa3194 100644 --- a/plat/ti/k3/common/plat_common.mk +++ b/plat/ti/k3/common/plat_common.mk @@ -44,10 +44,6 @@ $(eval $(call add_define,K3_USART)) K3_USART_BAUD := 115200 $(eval $(call add_define,K3_USART_BAUD)) -# Enable system suspend modes -K3_PM_SYSTEM_SUSPEND := 0 -$(eval $(call add_define,K3_PM_SYSTEM_SUSPEND)) - # Libraries include lib/xlat_tables_v2/xlat_tables.mk |