diff options
| author | Alex Chen <alex.chen@huawei.com> | 2020-12-03 13:50:43 +0000 |
|---|---|---|
| committer | Stefan Hajnoczi <stefanha@redhat.com> | 2021-01-04 11:13:39 +0000 |
| commit | 593621f36b716eb091c4ec791db72dd4461789da (patch) | |
| tree | 13d7ce0d638b9e9f578c3192dbde7cd9002ea87b /util | |
| parent | 41192db338588051f21501abc13743e62b0a5605 (diff) | |
readline: Fix possible array index out of bounds in readline_hist_add()
When the 'cmdline' is the last entry in 'rs->history' array, there is
no need to put this entry to the end of the array, partly because it is
the last entry, and partly because the next operition will lead to array
index out of bounds.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Alex Chen <alex.chen@huawei.com>
Message-id: 20201203135043.117072-1-alex.chen@huawei.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'util')
| -rw-r--r-- | util/readline.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/util/readline.c b/util/readline.c index e534460da6..f1ac6e4769 100644 --- a/util/readline.c +++ b/util/readline.c @@ -240,6 +240,9 @@ static void readline_hist_add(ReadLineState *rs, const char *cmdline) } if (strcmp(hist_entry, cmdline) == 0) { same_entry: + if (idx == READLINE_MAX_CMDS - 1) { + return; + } new_entry = hist_entry; /* Put this entry at the end of history */ memmove(&rs->history[idx], &rs->history[idx + 1], |