summaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorAlexChen <alex.chen@huawei.com>2020-10-30 10:46:55 +0800
committerJason Wang <jasowang@redhat.com>2020-11-11 16:53:01 +0800
commitd949fe64b074af7adca1076556aaebbcfdf6932e (patch)
tree99be52d374c300ebadb25c0d2bffcb3ee5af3bc4 /net
parent7564bf7701f00214cdc8a678a9f7df765244def1 (diff)
net/l2tpv3: Remove redundant check in net_init_l2tpv3()
The result has been checked to be NULL before, it cannot be NULL here, so the check is redundant. Remove it. Reported-by: Euler Robot <euler.robot@huawei.com> Signed-off-by: AlexChen <alex.chen@huawei.com> Signed-off-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'net')
-rw-r--r--net/l2tpv3.c9
1 files changed, 3 insertions, 6 deletions
diff --git a/net/l2tpv3.c b/net/l2tpv3.c
index 55fea17c0f..e4d4218db6 100644
--- a/net/l2tpv3.c
+++ b/net/l2tpv3.c
@@ -655,9 +655,8 @@ int net_init_l2tpv3(const Netdev *netdev,
error_setg(errp, "could not bind socket err=%i", errno);
goto outerr;
}
- if (result) {
- freeaddrinfo(result);
- }
+
+ freeaddrinfo(result);
memset(&hints, 0, sizeof(hints));
@@ -686,9 +685,7 @@ int net_init_l2tpv3(const Netdev *netdev,
memcpy(s->dgram_dst, result->ai_addr, result->ai_addrlen);
s->dst_size = result->ai_addrlen;
- if (result) {
- freeaddrinfo(result);
- }
+ freeaddrinfo(result);
if (l2tpv3->has_counter && l2tpv3->counter) {
s->has_counter = true;