From d363a88b31fc03268eada426f5940ef685b8df21 Mon Sep 17 00:00:00 2001 From: SF Markus Elfring Date: Mon, 5 Mar 2018 16:21:26 -0800 Subject: memory-EMIF: Use seq_putc() in emif_regdump_show() A single character (line break) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Santosh Shilimkar --- drivers/memory/emif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/memory') diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c index 04644e7b42b1..2f214440008c 100644 --- a/drivers/memory/emif.c +++ b/drivers/memory/emif.c @@ -127,7 +127,7 @@ static int emif_regdump_show(struct seq_file *s, void *unused) for (i = 0; i < EMIF_MAX_NUM_FREQUENCIES && regs_cache[i]; i++) { do_emif_regdump_show(s, emif, regs_cache[i]); - seq_printf(s, "\n"); + seq_putc(s, '\n'); } return 0; -- cgit v1.2.3 From a817e5d82a2dc5daaa0a8a66cfab268fdf2f6bb6 Mon Sep 17 00:00:00 2001 From: Wei Yongjun Date: Mon, 5 Mar 2018 16:21:31 -0800 Subject: memory: ti-emif-sram: remove redundant dev_err call in ti_emif_probe() There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun Signed-off-by: Santosh Shilimkar --- drivers/memory/ti-emif-pm.c | 1 - 1 file changed, 1 deletion(-) (limited to 'drivers/memory') diff --git a/drivers/memory/ti-emif-pm.c b/drivers/memory/ti-emif-pm.c index 62a86c4bcd0b..632651f4b6e8 100644 --- a/drivers/memory/ti-emif-pm.c +++ b/drivers/memory/ti-emif-pm.c @@ -271,7 +271,6 @@ static int ti_emif_probe(struct platform_device *pdev) emif_data->pm_data.ti_emif_base_addr_virt = devm_ioremap_resource(dev, res); if (IS_ERR(emif_data->pm_data.ti_emif_base_addr_virt)) { - dev_err(dev, "could not ioremap emif mem\n"); ret = PTR_ERR(emif_data->pm_data.ti_emif_base_addr_virt); return ret; } -- cgit v1.2.3