From 37c988d53afcab916e402e910017eaea2f9e01ba Mon Sep 17 00:00:00 2001 From: Dominik Kapusta Date: Wed, 21 Apr 2010 12:05:20 +0200 Subject: Fixes: NB#164850 - orientationFinished signals are sent even without change in orientation RevBy: Daniel d'Andrada Details: It makes sure that MSceneManager::orientationChangeFinished() is emitted with every orientation angle change. - Documentation updated to state that the signal comes after *every* rotation. - Internal MSceneManager::_q_changeGlobalOrientation() renamed to MSceneManager::_q_changeGlobalOrientationAngle() to tell precisely what does it do. - Test case updated. --- tests/ut_mscenemanager/ut_mscenemanager.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'tests/ut_mscenemanager') diff --git a/tests/ut_mscenemanager/ut_mscenemanager.cpp b/tests/ut_mscenemanager/ut_mscenemanager.cpp index df25bebf..48a5699b 100644 --- a/tests/ut_mscenemanager/ut_mscenemanager.cpp +++ b/tests/ut_mscenemanager/ut_mscenemanager.cpp @@ -205,7 +205,8 @@ void Ut_MSceneManager::testOrientationChangedSignal() void Ut_MSceneManager::testNoOrientationChangedSignalWhenRotatingBy180Degrees() { - QSignalSpy changedSpy(sm, SIGNAL(orientationChanged(M::Orientation))); + QSignalSpy orientationChangedSpy(sm, SIGNAL(orientationChanged(M::Orientation))); + QSignalSpy angleChangedSpy(sm, SIGNAL(orientationAngleChanged(M::OrientationAngle))); QSignalSpy finishedSpy(sm, SIGNAL(orientationChangeFinished(M::Orientation))); int newAngle = sm->orientationAngle() + M::Angle180; @@ -214,8 +215,9 @@ void Ut_MSceneManager::testNoOrientationChangedSignalWhenRotatingBy180Degrees() sm->setOrientationAngle((M::OrientationAngle) newAngle, MSceneManager::ImmediateTransition); - QCOMPARE(changedSpy.count(), 0); - QCOMPARE(finishedSpy.count(), 0); + QCOMPARE(orientationChangedSpy.count(), 0); + QCOMPARE(angleChangedSpy.count(), 1); + QCOMPARE(finishedSpy.count(), 1); } // Test uses non-exported symbol "MDockWidget". -- cgit v1.2.3