diff options
| author | Nick Alcock <nick.alcock@oracle.com> | 2020-06-04 18:07:38 +0100 |
|---|---|---|
| committer | Nick Alcock <nick.alcock@oracle.com> | 2020-07-22 18:02:18 +0100 |
| commit | e148b73013109517c4d179aa9ae5a50b6d1dd5b5 (patch) | |
| tree | f35a67a172a16852efc56d6d1fdbb586cf307dcc /libctf/ctf-error.c | |
| parent | 1fa7a0c24e78e7f7995a3fa608c9f97a6ccbe1b6 (diff) | |
libctf: drop error-prone ctf_strerror
This utility function is almost useless (all it does is casts the result
of a strerror) but has a seriously confusing name. Over and over again
I have accidentally called it instead of ctf_errmsg, and hidden a
time-bomb for myself in a hard-to-test error-handling path: since
ctf_strerror is just a strerror wrapper, it cannot handle CTF errnos,
unlike ctf_errmsg. It's astonishingly lucky that none of these errors
have crept into any commits to date.
Fuse it into ctf_errmsg and drop it.
libctf/
* ctf-impl.h (ctf_strerror): Delete.
* ctf-subr.c (ctf_strerror): Likewise.
* ctf-error.c (ctf_errmsg): Stop using ctf_strerror: just use
strerror directly.
Diffstat (limited to 'libctf/ctf-error.c')
| -rw-r--r-- | libctf/ctf-error.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/libctf/ctf-error.c b/libctf/ctf-error.c index 84d14d59323..20971f4275b 100644 --- a/libctf/ctf-error.c +++ b/libctf/ctf-error.c @@ -19,6 +19,7 @@ #include <ctf-impl.h> #include <stddef.h> +#include <string.h> /* This construct is due to Bruno Haible: much thanks. */ @@ -67,7 +68,7 @@ ctf_errmsg (int error) if (error >= ECTF_BASE && (error - ECTF_BASE) < ECTF_NERR) str = _ctf_errlist.str + _ctf_erridx[error - ECTF_BASE]; else - str = ctf_strerror (error); + str = (const char *) strerror (error); return (str ? str : "Unknown error"); } |