diff options
author | Alan Modra <amodra@gmail.com> | 2021-02-13 09:51:17 +1030 |
---|---|---|
committer | Alan Modra <amodra@gmail.com> | 2021-02-14 22:34:27 +1030 |
commit | 5b1f6c95704da7128ca2a7c682a2e0ef533180ce (patch) | |
tree | 0b17c5490260475e9df6d86e756656257a926e16 /ld/testsuite/ld-plugin | |
parent | f5b2658b0fbef02a855b7bb7288de051cc687237 (diff) |
ld testsuite: change unresolved to unsupported/fail
"unresolved" as a test result means runtest returns an error, which
can be confusing when there is no apparent error unless you look in
.log files. In particular many tests are skipped without reporting an
error if no target C compiler is found, but if a target C compiler is
found but won't compile a testcase for some reason we used to mark the
test as unresolved. Which is no more worthy of an error than when
lacking a C compiler entirely.
* testsuite/ld-cdtest/cdtest.exp,
* testsuite/ld-checks/checks.exp,
* testsuite/ld-elf/binutils.exp,
* testsuite/ld-elf/compress.exp,
* testsuite/ld-elf/dwarf.exp,
* testsuite/ld-elf/exclude.exp,
* testsuite/ld-elf/frame.exp,
* testsuite/ld-elf/indirect.exp,
* testsuite/ld-elf/linux-x86.exp,
* testsuite/ld-elf/sec-to-seg.exp,
* testsuite/ld-elf/tls_common.exp,
* testsuite/ld-elfcomm/elfcomm.exp,
* testsuite/ld-elfvers/vers.exp,
* testsuite/ld-elfvsb/elfvsb.exp,
* testsuite/ld-elfweak/elfweak.exp,
* testsuite/ld-ifunc/binutils.exp,
* testsuite/ld-mips-elf/mips-elf-flags.exp,
* testsuite/ld-misc/defsym.exp,
* testsuite/ld-mn10300/mn10300.exp,
* testsuite/ld-plugin/lto.exp,
* testsuite/ld-plugin/plugin.exp,
* testsuite/ld-scripts/align.exp,
* testsuite/ld-scripts/assert.exp,
* testsuite/ld-scripts/crossref.exp,
* testsuite/ld-scripts/defined.exp,
* testsuite/ld-scripts/extern.exp,
* testsuite/ld-scripts/log2.exp,
* testsuite/ld-scripts/map-address.exp,
* testsuite/ld-scripts/phdrs.exp,
* testsuite/ld-scripts/phdrs2.exp,
* testsuite/ld-scripts/script.exp,
* testsuite/ld-scripts/section-flags.exp,
* testsuite/ld-scripts/sizeof.exp,
* testsuite/ld-scripts/weak.exp,
* testsuite/ld-selective/selective.exp,
* testsuite/ld-sh/sh.exp,
* testsuite/ld-shared/shared.exp,
* testsuite/ld-srec/srec.exp,
* testsuite/ld-tic6x/tic6x.exp,
* testsuite/ld-undefined/undefined.exp,
* testsuite/ld-undefined/weak-undef.exp,
* testsuite/lib/ld-lib.exp: Don't use unresolved except after
perror. Instead report "unsupported" or "fail".
Diffstat (limited to 'ld/testsuite/ld-plugin')
-rw-r--r-- | ld/testsuite/ld-plugin/lto.exp | 2 | ||||
-rw-r--r-- | ld/testsuite/ld-plugin/plugin.exp | 12 |
2 files changed, 6 insertions, 8 deletions
diff --git a/ld/testsuite/ld-plugin/lto.exp b/ld/testsuite/ld-plugin/lto.exp index 33e5c19a230..38cea30aed4 100644 --- a/ld/testsuite/ld-plugin/lto.exp +++ b/ld/testsuite/ld-plugin/lto.exp @@ -679,7 +679,7 @@ set testname "Build liblto-11.a" remote_file host delete "tmpdir/liblto-11.a" set catch_output [run_host_cmd "$ar" "rc $plug_opt tmpdir/liblto-11.a tmpdir/lto-11a.o tmpdir/lto-11b.o tmpdir/lto-11c.o"] if {![string match "" $catch_output]} { - unresolved $testname + fail $testname restore_notify return } diff --git a/ld/testsuite/ld-plugin/plugin.exp b/ld/testsuite/ld-plugin/plugin.exp index 5825bc72b97..b8bf29e7ca0 100644 --- a/ld/testsuite/ld-plugin/plugin.exp +++ b/ld/testsuite/ld-plugin/plugin.exp @@ -25,11 +25,9 @@ if ![check_plugin_api_available] { # And a compiler to be available. set can_compile 1 -set failure_kind "unresolved" if { ![check_compiler_available] } { # Don't fail immediately, set can_compile 0 - set failure_kind "unsupported" } pass "plugin API enabled" @@ -286,11 +284,11 @@ set plugin_extra_elf_tests [list \ if { !$can_compile || $failed_compile } { foreach testitem $plugin_tests { - $failure_kind [lindex $testitem 0] + unsupported [lindex $testitem 0] } if { [is_elf_format] } { foreach testitem $plugin_extra_elf_tests { - $failure_kind [lindex $testitem 0] + unsupported [lindex $testitem 0] } } set CFLAGS "$old_CFLAGS" @@ -309,7 +307,7 @@ if { [is_elf_format] \ if {![ar_simple_create $ar "" "tmpdir/libtext.a" "tmpdir/text.o"] || \ ![ar_simple_create $ar "" "tmpdir/libempty.a" ""]} { foreach testitem $plugin_lib_tests { - unresolved [lindex $testitem 0] + unsupported [lindex $testitem 0] } } else { run_ld_link_tests $plugin_lib_tests @@ -373,7 +371,7 @@ if [ar_simple_create $ar "--plugin $plugin2_path" "tmpdir/libfunc.a" \ } } else { foreach testitem $plugin_src_tests { - unresolved [lindex $testitem 0] + unsupported [lindex $testitem 0] } } @@ -393,7 +391,7 @@ if [ar_simple_create $ar "--plugin $plugin4_path" "tmpdir/libpr20070.a" \ ] \ ] } else { - unresolved "PR ld/20070" + unsupported "PR ld/20070" } set CFLAGS "$old_CFLAGS" |