diff options
| author | Aaron Merey <amerey@redhat.com> | 2023-02-09 20:28:20 -0500 |
|---|---|---|
| committer | Aaron Merey <amerey@redhat.com> | 2023-02-10 21:04:45 -0500 |
| commit | 40dfb28b56fe55a370a35495e0f1eb6c95110f35 (patch) | |
| tree | e5a51168f2bf2aef021346f20844ac505dcdd924 /gdbserver | |
| parent | bad727e2d2d1d7f86e1bcdb8eb9ce778182b5926 (diff) | |
Move implementation of perror_with_name to gdbsupport
gdbsupport/errors.h declares perror_with_name and leaves the
implementation to the clients.
However gdb and gdbserver's implementations are essentially the
same, resulting in unnecessary code duplication.
Fix this by implementing perror_with_name in gdbsupport. Add an
optional parameter for specifying the errno used to generate the
error message.
Also move the implementation of perror_string to gdbsupport since
perror_with_name requires it.
Approved-By: Tom Tromey <tom@tromey.com>
Diffstat (limited to 'gdbserver')
| -rw-r--r-- | gdbserver/utils.cc | 22 |
1 files changed, 0 insertions, 22 deletions
diff --git a/gdbserver/utils.cc b/gdbserver/utils.cc index a6f5bd7b600..511364cfed2 100644 --- a/gdbserver/utils.cc +++ b/gdbserver/utils.cc @@ -51,28 +51,6 @@ malloc_failure (long size) abort_or_exit (); } -/* Print the system error message for errno, and also mention STRING - as the file name for which the error was encountered. - Then return to command level. */ - -void -perror_with_name (const char *string) -{ - const char *err; - char *combined; - - err = safe_strerror (errno); - if (err == NULL) - err = "unknown error"; - - combined = (char *) alloca (strlen (err) + strlen (string) + 3); - strcpy (combined, string); - strcat (combined, ": "); - strcat (combined, err); - - error ("%s.", combined); -} - /* Print an error message and return to top level. */ void |