summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohn Stultz <john.stultz@linaro.org>2017-09-07 11:47:17 -0700
committerAmit Pundir <amit.pundir@linaro.org>2023-10-30 11:07:10 +0530
commit7f1402c50d3d639c840c6106da6b05b3cf4f3431 (patch)
tree05b56bf252548cff1fa2ceb18dbb7f2838603f78
parent89096ae24fa7704592f9340b3a6095ab991935db (diff)
ANDROID: Allow CAP_SYS_NICE tasks to migrate processes between cgroups
This hack allows CAP_SYS_NICE tasks to have privledge to migrate other tasks between cgroups. This is used by the system_service to migrate processes between top-app, foreground, background cgroups for cputime and schedtune groups. Fixes following libprocessgroup error loop in logcat: ----------- E libprocessgroup: AddTidToCgroup failed to write '$ABCD'; fd=$XYZ: Permission denied E libprocessgroup: Failed to add task into cgroup ----------- Signed-off-by: John Stultz <john.stultz@linaro.org> Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
-rw-r--r--kernel/cgroup/cgroup-v1.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/kernel/cgroup/cgroup-v1.c b/kernel/cgroup/cgroup-v1.c
index 76db6c67e39a..269c9f1214bb 100644
--- a/kernel/cgroup/cgroup-v1.c
+++ b/kernel/cgroup/cgroup-v1.c
@@ -513,7 +513,8 @@ static ssize_t __cgroup1_procs_write(struct kernfs_open_file *of,
tcred = get_task_cred(task);
if (!uid_eq(cred->euid, GLOBAL_ROOT_UID) &&
!uid_eq(cred->euid, tcred->uid) &&
- !uid_eq(cred->euid, tcred->suid))
+ !uid_eq(cred->euid, tcred->suid) &&
+ !ns_capable(tcred->user_ns, CAP_SYS_NICE))
ret = -EACCES;
put_cred(tcred);
if (ret)