aboutsummaryrefslogtreecommitdiff
path: root/scripts
diff options
context:
space:
mode:
authorPhilippe Mathieu-Daudé <philmd@linaro.org>2023-06-01 11:34:51 +0200
committerThomas Huth <thuth@redhat.com>2023-06-05 20:48:34 +0200
commite3e2c0c82bd0b9678f7950f37f9a089301d47813 (patch)
treea74886f044c47a29eae7c43c87c277676ec1851c /scripts
parentdc96009afd8cf2372fa1bbced0bcbcbb2c5d6f1b (diff)
scripts: Add qom-cast-macro-clean-cocci-gen.py
Add a script to generate Coccinelle semantic patch removing all pointless QOM cast macro uses. Suggested-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Message-Id: <20230601093452.38972-2-philmd@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'scripts')
-rw-r--r--scripts/qom-cast-macro-clean-cocci-gen.py49
1 files changed, 49 insertions, 0 deletions
diff --git a/scripts/qom-cast-macro-clean-cocci-gen.py b/scripts/qom-cast-macro-clean-cocci-gen.py
new file mode 100644
index 0000000000..2fa8438a14
--- /dev/null
+++ b/scripts/qom-cast-macro-clean-cocci-gen.py
@@ -0,0 +1,49 @@
+#!/usr/bin/env python3
+#
+# Generate a Coccinelle semantic patch to remove pointless QOM cast.
+#
+# Usage:
+#
+# $ qom-cast-macro-clean-cocci-gen.py $(git ls-files) > qom_pointless_cast.cocci
+# $ spatch \
+# --macro-file scripts/cocci-macro-file.h \
+# --sp-file qom_pointless_cast.cocci \
+# --keep-comments \
+# --use-gitgrep \
+# --in-place \
+# --dir .
+#
+# SPDX-FileContributor: Philippe Mathieu-Daudé <philmd@linaro.org>
+# SPDX-FileCopyrightText: 2023 Linaro Ltd.
+# SPDX-License-Identifier: GPL-2.0-or-later
+
+import re
+import sys
+
+assert len(sys.argv) > 0
+
+def print_cocci_rule(qom_typedef, qom_cast_macro):
+ print(f'''@@
+typedef {qom_typedef};
+{qom_typedef} *obj;
+@@
+- {qom_cast_macro}(obj)
++ obj
+''')
+
+patterns = [
+ r'DECLARE_INSTANCE_CHECKER\((\w+),\W*(\w+),\W*TYPE_\w+\)',
+ r'DECLARE_OBJ_CHECKERS\((\w+),\W*\w+,\W*(\w+),\W*TYPE_\w+\)',
+ r'OBJECT_DECLARE_TYPE\((\w+),\W*\w+,\W*(\w+)\)',
+ r'OBJECT_DECLARE_SIMPLE_TYPE\((\w+),\W*(\w+)\)',
+ r'INTERFACE_CHECK\((\w+),\W*\(\w+\),\W*TYPE_(\w+)\)',
+]
+
+for fn in sys.argv[1:]:
+ try:
+ content = open(fn, 'rt').read()
+ except:
+ continue
+ for pattern in patterns:
+ for match in re.findall(pattern, content):
+ print_cocci_rule(match[0], match[1])