diff options
| author | Markus Armbruster <armbru@redhat.com> | 2019-08-12 07:23:56 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2019-08-16 13:31:53 +0200 |
| commit | d5938f29fea29581725426f203a74da746ca03e7 (patch) | |
| tree | 0caa694b1084f73004a8eacced417b1ef3073fcc /net | |
| parent | b58c5c2dd29db0eae0bed800ac1a311e14007cec (diff) | |
Clean up inclusion of sysemu/sysemu.h
In my "build everything" tree, changing sysemu/sysemu.h triggers a
recompile of some 5400 out of 6600 objects (not counting tests and
objects that don't depend on qemu/osdep.h).
Almost a third of its inclusions are actually superfluous. Delete
them. Downgrade two more to qapi/qapi-types-run-state.h, and move one
from char/serial.h to char/serial.c.
hw/semihosting/config.c, monitor/monitor.c, qdev-monitor.c, and
stubs/semihost.c define variables declared in sysemu/sysemu.h without
including it. The compiler is cool with that, but include it anyway.
This doesn't reduce actual use much, as it's still included into
widely included headers. The next commit will tackle that.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20190812052359.30071-27-armbru@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/tap-bsd.c | 1 | ||||
| -rw-r--r-- | net/tap-linux.c | 1 | ||||
| -rw-r--r-- | net/tap-solaris.c | 1 | ||||
| -rw-r--r-- | net/tap-win32.c | 1 |
4 files changed, 0 insertions, 4 deletions
diff --git a/net/tap-bsd.c b/net/tap-bsd.c index 5695e3dd1f..a5c3707f80 100644 --- a/net/tap-bsd.c +++ b/net/tap-bsd.c @@ -27,7 +27,6 @@ #include "qapi/error.h" #include "tap_int.h" #include "qemu/cutils.h" -#include "sysemu/sysemu.h" #include "qemu/error-report.h" #if defined(__NetBSD__) || defined(__FreeBSD__) diff --git a/net/tap-linux.c b/net/tap-linux.c index 941a45d7c3..e0dd442ee3 100644 --- a/net/tap-linux.c +++ b/net/tap-linux.c @@ -32,7 +32,6 @@ #include <net/if.h> #include <sys/ioctl.h> -#include "sysemu/sysemu.h" #include "qapi/error.h" #include "qemu/error-report.h" #include "qemu/cutils.h" diff --git a/net/tap-solaris.c b/net/tap-solaris.c index 0e3f3e0a9b..4725d2314e 100644 --- a/net/tap-solaris.c +++ b/net/tap-solaris.c @@ -25,7 +25,6 @@ #include "qemu/osdep.h" #include "qapi/error.h" #include "tap_int.h" -#include "sysemu/sysemu.h" #include "qemu/ctype.h" #include "qemu/cutils.h" diff --git a/net/tap-win32.c b/net/tap-win32.c index 9cdef47286..2b5dcda36e 100644 --- a/net/tap-win32.c +++ b/net/tap-win32.c @@ -33,7 +33,6 @@ #include "clients.h" /* net_init_tap */ #include "net/net.h" #include "net/tap.h" /* tap_has_ufo, ... */ -#include "sysemu/sysemu.h" #include "qemu/error-report.h" #include "qemu/main-loop.h" #include <windows.h> |