aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJakub Jelinek <jakub@redhat.com>2009-03-26 19:27:17 +0000
committerJakub Jelinek <jakub@redhat.com>2009-03-26 19:27:17 +0000
commit280f4437d9cc7f101347e5e505fa678083a1ca8e (patch)
treedc79a6a82c49de520ee04b9143b1f107c22fa275
parentdb9b02b5ba9dd55bdb197e9013a9f1d666165ede (diff)
PR c++/39554
* opts.c (warn_if_disallowed_function_p): Don't assume get_callee_fndecl must return non-NULL. * gcc.dg/wdisallowed-functions-3.c: New test. * g++.dg/warn/Wdisallowed-functions-3.C: New test. git-svn-id: https://gcc.gnu.org/svn/gcc/trunk@145094 138bc75d-0d04-0410-961f-82ee72b054a4
-rw-r--r--gcc/ChangeLog6
-rw-r--r--gcc/opts.c14
-rw-r--r--gcc/testsuite/ChangeLog6
-rw-r--r--gcc/testsuite/g++.dg/warn/Wdisallowed-functions-3.C10
-rw-r--r--gcc/testsuite/gcc.dg/wdisallowed-functions-3.c10
5 files changed, 43 insertions, 3 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 947f34f30a2..14fdabfaff8 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2009-03-26 Jakub Jelinek <jakub@redhat.com>
+
+ PR c++/39554
+ * opts.c (warn_if_disallowed_function_p): Don't assume
+ get_callee_fndecl must return non-NULL.
+
2009-03-26 Vladimir Makarov <vmakarov@redhat.com>
PR rtl-optimization/39522
diff --git a/gcc/opts.c b/gcc/opts.c
index 631977097ec..2d5184fcb0e 100644
--- a/gcc/opts.c
+++ b/gcc/opts.c
@@ -745,13 +745,21 @@ flag_instrument_functions_exclude_p (tree fndecl)
void
warn_if_disallowed_function_p (const_tree exp)
{
- if (TREE_CODE(exp) == CALL_EXPR
+ if (TREE_CODE (exp) == CALL_EXPR
&& VEC_length (char_p, warning_disallowed_functions) > 0)
{
int i;
char *s;
- const char *fnname =
- IDENTIFIER_POINTER (DECL_NAME (get_callee_fndecl (exp)));
+ tree fndecl = get_callee_fndecl (exp);
+ const char *fnname;
+
+ if (fndecl == NULL)
+ return;
+
+ fnname = get_name (fndecl);
+ if (fnname == NULL)
+ return;
+
for (i = 0; VEC_iterate (char_p, warning_disallowed_functions, i, s);
++i)
{
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 0bc39a28ab3..e3e6ab4932d 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2009-03-26 Jakub Jelinek <jakub@redhat.com>
+
+ PR c++/39554
+ * gcc.dg/wdisallowed-functions-3.c: New test.
+ * g++.dg/warn/Wdisallowed-functions-3.C: New test.
+
2009-03-26 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
* gcc.dg/inline-33.c: Fix when pic.
diff --git a/gcc/testsuite/g++.dg/warn/Wdisallowed-functions-3.C b/gcc/testsuite/g++.dg/warn/Wdisallowed-functions-3.C
new file mode 100644
index 00000000000..3ecfb0c2264
--- /dev/null
+++ b/gcc/testsuite/g++.dg/warn/Wdisallowed-functions-3.C
@@ -0,0 +1,10 @@
+// PR c++/39554
+// { dg-do compile }
+// { dg-options "-Wdisallowed-function-list=bar" }
+
+void
+foo (void (*p) (), void (*bar) ())
+{
+ p ();
+ bar ();
+}
diff --git a/gcc/testsuite/gcc.dg/wdisallowed-functions-3.c b/gcc/testsuite/gcc.dg/wdisallowed-functions-3.c
new file mode 100644
index 00000000000..5b8b31bdfc9
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/wdisallowed-functions-3.c
@@ -0,0 +1,10 @@
+/* PR c++/39554 */
+/* { dg-do compile } */
+/* { dg-options "-Wdisallowed-function-list=bar" } */
+
+void
+foo (void (*p) (void), void (*bar) (void))
+{
+ p ();
+ bar ();
+}