From 7661dfff1528e907381ae49762ee12950b391449 Mon Sep 17 00:00:00 2001 From: Sunny Wang Date: Mon, 10 May 2021 17:08:49 +0800 Subject: Platform/RaspberryPi: Update ACPI table revision As per ACPI 6.3 specification, the DSDT/SSDT table should use revision 2 , so update the revision numbers to 2. This also fixes https://github.com/pftf/RPi4/issues/94 (FWTS failures). Testing Done: - Booted to UEFI Shell and used apciview command to check all ACPI tables' revision. - Ran FWTS test and no longer see the ACPI DSDT and SSDT revision failures. Note that the XSDT revision failure is caused by the FWTS tool's issue that got fixed in commit c522bfedc9839a474b8d590ba36bec77436d2e90 Cc: Samer El-Haj-Mahmoud Cc: Jeremy Linton Cc: Sami Mujawar Cc: Pete Batard Cc: Ard Biesheuvel Signed-off-by: Sunny Wang Reviewed-by: Pete Batard Tested-by: Pete Batard # Windows 10 boot --- Platform/RaspberryPi/AcpiTables/Dsdt.asl | 3 ++- Platform/RaspberryPi/AcpiTables/Emmc.asl | 4 ++-- Platform/RaspberryPi/AcpiTables/SsdtThermal.asl | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/Platform/RaspberryPi/AcpiTables/Dsdt.asl b/Platform/RaspberryPi/AcpiTables/Dsdt.asl index d116f965..54fa3eca 100644 --- a/Platform/RaspberryPi/AcpiTables/Dsdt.asl +++ b/Platform/RaspberryPi/AcpiTables/Dsdt.asl @@ -5,6 +5,7 @@ * Copyright (c) 2020, Pete Batard * Copyright (c) 2018-2020, Andrey Warkentin * Copyright (c) Microsoft Corporation. All rights reserved. + * Copyright (c) 2021, ARM Limited. All rights reserved. * * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -58,7 +59,7 @@ Store (Length, LE ## Index) \ Add (MI ## Index, LE ## Index - 1, MA ## Index) -DefinitionBlock ("Dsdt.aml", "DSDT", 5, "RPIFDN", "RPI", 2) +DefinitionBlock ("Dsdt.aml", "DSDT", 2, "RPIFDN", "RPI", 2) { Scope (\_SB_) { diff --git a/Platform/RaspberryPi/AcpiTables/Emmc.asl b/Platform/RaspberryPi/AcpiTables/Emmc.asl index 179dd3ec..88811eb3 100644 --- a/Platform/RaspberryPi/AcpiTables/Emmc.asl +++ b/Platform/RaspberryPi/AcpiTables/Emmc.asl @@ -1,6 +1,6 @@ /** @file * - * Copyright (c) 2021 Arm. All rights reserved. + * Copyright (c) 2021, ARM Limited. All rights reserved. * * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -11,7 +11,7 @@ #include "AcpiTables.h" -DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", "RPI4EMMC", 2) +DefinitionBlock (__FILE__, "SSDT", 2, "RPIFDN", "RPI4EMMC", 2) { Scope (\_SB_) { diff --git a/Platform/RaspberryPi/AcpiTables/SsdtThermal.asl b/Platform/RaspberryPi/AcpiTables/SsdtThermal.asl index 862637ac..40e40b0d 100644 --- a/Platform/RaspberryPi/AcpiTables/SsdtThermal.asl +++ b/Platform/RaspberryPi/AcpiTables/SsdtThermal.asl @@ -14,7 +14,7 @@ #include -DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", "RPITHFAN", 2) +DefinitionBlock (__FILE__, "SSDT", 2, "RPIFDN", "RPITHFAN", 2) { External (\_SB_.EC00, DeviceObj) External (\_SB_.EC00.TZ00, DeviceObj) -- cgit v1.2.3