From 05579e51824a1ea393e52a3bda7d0c35cb060bc3 Mon Sep 17 00:00:00 2001 From: Michael D Kinney Date: Thu, 1 Aug 2019 15:57:18 -0700 Subject: BaseTools/PatchCheck: Ignore blank lines in diff https://bugzilla.tianocore.org/show_bug.cgi?id=2044 When fixes are made for incorrect line endings, there are cases where the diff contains blank lines. Ignore these blank lines. Cc: Bob Feng Cc: Liming Gao Cc: Jordan Justen Signed-off-by: Michael D Kinney Reviewed-by: Bob Feng Reviewed-by: Liming Gao Reviewed-by: Jordan Justen --- BaseTools/Scripts/PatchCheck.py | 3 +++ 1 file changed, 3 insertions(+) (limited to 'BaseTools/Scripts') diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py index 6aec15d0f0..4f2ef81ae7 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -270,6 +270,7 @@ class GitDiffCheck: if line.startswith('@@ '): self.state = PRE_PATCH elif len(line) >= 1 and line[0] not in ' -+' and \ + not line.startswith('\r\n') and \ not line.startswith(r'\ No newline ') and not self.binary: for line in self.lines[self.line_num + 1:]: if line.startswith('diff --git'): @@ -313,6 +314,8 @@ class GitDiffCheck: pass elif line.startswith('+'): self.check_added_line(line[1:]) + elif line.startswith('\r\n'): + pass elif line.startswith(r'\ No newline '): pass elif not line.startswith(' '): -- cgit v1.2.3