diff options
| author | Aya Levin <ayal@mellanox.com> | 2019-10-02 17:35:16 +0300 |
|---|---|---|
| committer | Stephen Hemminger <stephen@networkplumber.org> | 2019-10-08 20:22:13 -0700 |
| commit | 94ff4d68822492a93141f79f5e7015a0a4e9056f (patch) | |
| tree | 90e5f12f45178cf76cecae34fb4e35fd0b3c3a8c | |
| parent | 7dd3d51b9137e51c667c9c05df3ec3e5009ca157 (diff) | |
devlink: Fix inconsistency between command input and output
In devlink health show command the reporter's name parameter is called
reporter, but in the output the reporter's name is referred to as name
Before this patch:
$ devlink health show pci/0000:04:00.0 reporter tx
pci/0000:04:00.0:
name tx
state healthy error 0 recover 0 grace_period 500 auto_recover true
After this patch:
$ devlink health show pci/0000:04:00.0 reporter tx
pci/0000:04:00.0:
reporter tx
state healthy error 0 recover 0 grace_period 500 auto_recover true
Reported-by: Jiri Pirko <jiri@mellanox.com>
Fixes: 2f1242efe9d0 ("devlink: Add devlink health show command")
Signed-off-by: Aya Levin <ayal@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
| -rw-r--r-- | devlink/devlink.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/devlink/devlink.c b/devlink/devlink.c index 50baf82a..5bbe0bdd 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -6660,7 +6660,7 @@ static void pr_out_health(struct dl *dl, struct nlattr **tb_health) pr_out_handle_start_arr(dl, tb_health); - pr_out_str(dl, "name", + pr_out_str(dl, "reporter", mnl_attr_get_str(tb[DEVLINK_ATTR_HEALTH_REPORTER_NAME])); if (!dl->json_output) { __pr_out_newline(); |