summaryrefslogtreecommitdiff
path: root/qcom
diff options
context:
space:
mode:
authorPeter Collingbourne <pcc@google.com>2020-10-20 00:15:44 -0700
committerPeter Collingbourne <pcc@google.com>2020-10-20 13:39:19 -0700
commitebef015a20ca2b7a7b0ec49f94539886312c2705 (patch)
tree033be6f6a37b8245104816c798a11cc17011bfcb /qcom
parent30b93bcd6dbd7521814f80156691d4ea16a1063f (diff)
Fix an out-of-bounds read in assoc_next.
Found using HWASan. Also sent upstream: https://github.com/andersson/pd-mapper/pull/5 Bug: 171327997 Change-Id: I69d07d0228719abbffb38aa709de39c1d8190158
Diffstat (limited to 'qcom')
-rw-r--r--qcom/pd-mapper/assoc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/qcom/pd-mapper/assoc.c b/qcom/pd-mapper/assoc.c
index 692c882..460f0d0 100644
--- a/qcom/pd-mapper/assoc.c
+++ b/qcom/pd-mapper/assoc.c
@@ -128,7 +128,7 @@ const char *assoc_next(struct assoc *assoc, void **value, unsigned long *iter)
{
unsigned long it = *iter;
- while (!assoc->keys[it] && it < assoc->size)
+ while (it < assoc->size && !assoc->keys[it])
it++;
if (it == assoc->size)