diff options
author | David S. Miller <davem@davemloft.net> | 2015-05-01 22:02:47 -0400 |
---|---|---|
committer | Mark Salyzyn <salyzyn@google.com> | 2015-05-04 07:23:14 -0700 |
commit | 858c4e49d1acb72a3c32711f0cbe8cf14b0f663a (patch) | |
tree | c7ad0b75a1975029beacfd6a9e16b6560415cb3f /net/ipv4/ping.c | |
parent | 5ab8b1104af542d07c80930c58f558cbbca319af (diff) |
ipv4: Missing sk_nulls_node_init() in ping_unhash().
If we don't do that, then the poison value is left in the ->pprev
backlink.
This can cause crashes if we do a disconnect, followed by a connect().
Tested-by: Linus Torvalds <torvalds@linux-foundation.org>
Reported-by: Wen Xu <hotdog3645@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Bug: 20770158
Change-Id: I944eb20fddea190892c2da681d934801d268096d
Diffstat (limited to 'net/ipv4/ping.c')
-rw-r--r-- | net/ipv4/ping.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c index 44db7664ec7..18f4359118e 100644 --- a/net/ipv4/ping.c +++ b/net/ipv4/ping.c @@ -158,6 +158,7 @@ void ping_unhash(struct sock *sk) if (sk_hashed(sk)) { write_lock_bh(&ping_table.lock); hlist_nulls_del(&sk->sk_nulls_node); + sk_nulls_node_init(&sk->sk_nulls_node); sock_put(sk); isk->inet_num = 0; isk->inet_sport = 0; |