diff options
| author | Philippe Mathieu-Daude <philmd@redhat.com> | 2019-12-05 19:19:42 +0800 |
|---|---|---|
| committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2019-12-06 03:07:37 +0000 |
| commit | e8b9296c67dffaddd26dce06d8daaca6206fa620 (patch) | |
| tree | 036e1052a4eae7c45ce73261446908ef3367508f /.pytool | |
| parent | 0f9395d7c5cc6ae2beaa2d87008fe158d04a8069 (diff) | |
.pytool: Avoid "is" with a literal Python 3.8 warnings in CI plugins
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2304
To avoid SyntaxWarning with Python 3.8, change the 'is' operator
by the conventional '==' comparator.
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
Diffstat (limited to '.pytool')
| -rw-r--r-- | .pytool/Plugin/DscCompleteCheck/DscCompleteCheck.py | 2 | ||||
| -rw-r--r-- | .pytool/Plugin/LibraryClassCheck/LibraryClassCheck.py | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/.pytool/Plugin/DscCompleteCheck/DscCompleteCheck.py b/.pytool/Plugin/DscCompleteCheck/DscCompleteCheck.py index e2485f5708..9af4f72c8d 100644 --- a/.pytool/Plugin/DscCompleteCheck/DscCompleteCheck.py +++ b/.pytool/Plugin/DscCompleteCheck/DscCompleteCheck.py @@ -61,7 +61,7 @@ class DscCompleteCheck(ICiBuildPlugin): abs_dsc_path = os.path.join(abs_pkg_path, pkgconfig["DscPath"].strip())
wsr_dsc_path = Edk2pathObj.GetEdk2RelativePathFromAbsolutePath(abs_dsc_path)
- if abs_dsc_path is None or wsr_dsc_path is "" or not os.path.isfile(abs_dsc_path):
+ if abs_dsc_path is None or wsr_dsc_path == "" or not os.path.isfile(abs_dsc_path):
tc.SetSkipped()
tc.LogStdError("Package Dsc not found")
return 0
diff --git a/.pytool/Plugin/LibraryClassCheck/LibraryClassCheck.py b/.pytool/Plugin/LibraryClassCheck/LibraryClassCheck.py index 5dafcbc13f..a62a7e912b 100644 --- a/.pytool/Plugin/LibraryClassCheck/LibraryClassCheck.py +++ b/.pytool/Plugin/LibraryClassCheck/LibraryClassCheck.py @@ -67,7 +67,7 @@ class LibraryClassCheck(ICiBuildPlugin): abs_dec_path = self.__GetPkgDec(abs_pkg_path)
wsr_dec_path = Edk2pathObj.GetEdk2RelativePathFromAbsolutePath(abs_dec_path)
- if abs_dec_path is None or wsr_dec_path is "" or not os.path.isfile(abs_dec_path):
+ if abs_dec_path is None or wsr_dec_path == "" or not os.path.isfile(abs_dec_path):
tc.SetSkipped()
tc.LogStdError("No DEC file {0} in package {1}".format(abs_dec_path, abs_pkg_path))
return -1
|