From bebb49125fd305ae7814d7d4fcc05a85cc2a21e0 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Fri, 20 Nov 2020 08:28:11 +0100 Subject: x86/nmi: avoid UB for P4-era watchdogs Found by looking for patterns similar to the one Julien did spot in pci_vtd_quirks(). Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- xen/arch/x86/nmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'xen') diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c index 014524486f..ab94a96c4d 100644 --- a/xen/arch/x86/nmi.c +++ b/xen/arch/x86/nmi.c @@ -132,7 +132,7 @@ int nmi_active; #define P4_ESCR_EVENT_SELECT(N) ((N)<<25) #define P4_CCCR_OVF_PMI0 (1<<26) #define P4_CCCR_OVF_PMI1 (1<<27) -#define P4_CCCR_OVF (1<<31) +#define P4_CCCR_OVF (1u << 31) #define P4_CCCR_THRESHOLD(N) ((N)<<20) #define P4_CCCR_COMPLEMENT (1<<19) #define P4_CCCR_COMPARE (1<<18) -- cgit v1.2.3