diff options
| author | Andrew Cooper <andrew.cooper3@citrix.com> | 2018-08-29 16:39:10 +0000 |
|---|---|---|
| committer | Andrew Cooper <andrew.cooper3@citrix.com> | 2018-09-11 10:33:46 +0100 |
| commit | 25eb5eec796f5a965fda37c2968b3b7dd738eb72 (patch) | |
| tree | f859a03904a62fff63c37dc7371d876132b49b7f /xen/arch/x86/numa.c | |
| parent | 66b245d9eaebfef710148d410ae97a2eaedc3170 (diff) | |
xen: Fix inconsistent callers of panic()
Callers are inconsistent with whether they pass a newline to panic(),
including adjacent calls in the same function using different styles.
painc() not expecting a newline is inconsistent with most other printing
functions, which is most likely why we've gained so many inconsistencies.
Switch panic() to expect a newline, and update all callers which currently
lack a newline to include one.
This actually reduces the size of .rodata (0x07e3e8 down to 0x07e3a8) because
a number of strings are passed to both panic() and printk(). As they
previously differed by \n alone, they couldn't be merged.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Julien Grall <julien.grall@arm.com>
Diffstat (limited to 'xen/arch/x86/numa.c')
| -rw-r--r-- | xen/arch/x86/numa.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index a87987da6f..0498cbd1e3 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -357,7 +357,7 @@ unsigned int __init arch_get_dma_bitsize(void) !(node_start_pfn(node) >> (32 - PAGE_SHIFT)) ) break; if ( node >= MAX_NUMNODES ) - panic("No node with memory below 4Gb"); + panic("No node with memory below 4Gb\n"); /* * Try to not reserve the whole node's memory for DMA, but dividing |