xenserver: Fix "brctl show" compatibility by introducing "brctl" wrapper.

Bug NIC-19, which reported that "brctl show" did not format its output in
the way expected by Citrix QA scripts, was believed fixed by commit
35c979bff4 "vswitchd: Support creating fake bond device interfaces."
Unfortunately, this commit was not tested on a XenServer before it was
committed.  Due to differences in the actual test environment and the
XenServer environment, which have different versions of the bridge-utils
package that contains brctl, that commit did not fix the problem observed
by Citrix QA.  In particular, the XenServer brctl uses sysfs to obtain
the information displayed by "brctl show", but the previous commit only
fixed up the information output by the bridge ioctls.

The natural way to fix this problem would be to fix up the sysfs support
as well.  I started out along that path, but became bogged down in all
the details of the kernel sysfs.

This commit takes an alternate approach, by introducing a wrapper around
the system brctl binary that implements "brctl show" itself and delegates
all other functionality to the original binary (in a different location).
This will not fix tools that do not call into brctl, but to the best of
my knowledge there are no such tools used in the Citrix QA process.

Thanks to Justin and Reid for much feedback.

Bug NIC-19.

1 files changed, 5 insertions, 0 deletions

diff --git a/xenserver/README b/xenserver/README
index 6c91e941..b940e3f7 100644
--- a/xenserver/README
+++ b/xenserver/README
@@ -60,6 +60,11 @@ files are:
         used to control vswitch when integrated with Citrix management
         tools.
 
+    usr_sbin_brctl
+
+        wrapper for /usr/sbin/brctl that provides some additional
+        bridge compatibility
+
     usr_sbin_xen-bugtool
 
         vswitch-aware replacement for Citrix script of the same name.