aboutsummaryrefslogtreecommitdiff
path: root/vswitchd
diff options
context:
space:
mode:
authorBen Pfaff <blp@nicira.com>2010-02-10 11:07:28 -0800
committerBen Pfaff <blp@nicira.com>2010-02-11 10:35:28 -0800
commit4869f1b170c1741fbc8f81123d0fe5fc1ba3a282 (patch)
treed647daa44bd95b9dd6ffa5a8dcfa3daee37c19b5 /vswitchd
parent02ef592c379d359bb447ae5fbb709e485dcb5103 (diff)
ovs-brcompatd: Use error instead of pointer in handle_fdb_query_cmd().
It is safe to use either value here but as long as we are saving the error value we might as well use it. Found by Clang (http://clang-analyzer.llvm.org/).
Diffstat (limited to 'vswitchd')
-rw-r--r--vswitchd/ovs-brcompatd.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/vswitchd/ovs-brcompatd.c b/vswitchd/ovs-brcompatd.c
index beaefb2e..faf1bee3 100644
--- a/vswitchd/ovs-brcompatd.c
+++ b/vswitchd/ovs-brcompatd.c
@@ -756,7 +756,7 @@ handle_fdb_query_cmd(const struct ovsrec_open_vswitch *ovs,
struct netdev *netdev;
error = netdev_open_default(iface_name, &netdev);
- if (netdev) {
+ if (!error) {
if (!netdev_get_etheraddr(netdev, mac->addr)) {
n_local_macs++;
}