diff options
author | Justin Pettit <jpettit@nicira.com> | 2011-10-12 00:03:10 -0700 |
---|---|---|
committer | Justin Pettit <jpettit@nicira.com> | 2011-10-12 14:58:52 -0700 |
commit | 070723f9fe70adf623acb519e249babfa7f40804 (patch) | |
tree | 95463701f00efad8644a20c79c222d0addf622c8 /utilities | |
parent | dae57238bc0ae2527b7d6f95482c5f17cba2e16e (diff) |
ovs-vsctl: Print warning for invalid controller and manager targets.
Diffstat (limited to 'utilities')
-rw-r--r-- | utilities/ovs-vsctl.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c index df5150ff..a8b10118 100644 --- a/utilities/ovs-vsctl.c +++ b/utilities/ovs-vsctl.c @@ -45,6 +45,7 @@ #include "table.h" #include "timeval.h" #include "util.h" +#include "vconn.h" #include "vlog.h" VLOG_DEFINE_THIS_MODULE(vsctl); @@ -2010,6 +2011,9 @@ insert_controllers(struct ovsdb_idl_txn *txn, char *targets[], size_t n) controllers = xmalloc(n * sizeof *controllers); for (i = 0; i < n; i++) { + if (vconn_verify_name(targets[i]) && pvconn_verify_name(targets[i])) { + VLOG_WARN("target type \"%s\" is possibly erroneous", targets[i]); + } controllers[i] = ovsrec_controller_insert(txn); ovsrec_controller_set_target(controllers[i], targets[i]); } @@ -2168,6 +2172,9 @@ insert_managers(struct vsctl_context *ctx, char *targets[], size_t n) /* Insert each manager in a new row in Manager table. */ managers = xmalloc(n * sizeof *managers); for (i = 0; i < n; i++) { + if (stream_verify_name(targets[i]) && pstream_verify_name(targets[i])) { + VLOG_WARN("target type \"%s\" is possibly erroneous", targets[i]); + } managers[i] = ovsrec_manager_insert(ctx->txn); ovsrec_manager_set_target(managers[i], targets[i]); } |