aboutsummaryrefslogtreecommitdiff
path: root/ofproto
diff options
context:
space:
mode:
authorEthan Jackson <ethan@nicira.com>2013-02-21 19:13:16 -0800
committerEthan Jackson <ethan@nicira.com>2013-02-25 11:17:23 -0800
commitf87c28130d975b82cb867923cf81e063e602993a (patch)
treee61e13bf835467a484400138de4bc16c1a1b1ad0 /ofproto
parent13da9ac40df6d805968edab0445739fe2add31cf (diff)
in-band: Use "internal" netdev type for local ports.
A bridge's local port always has type "internal", so opening it with type "system" can't be correct. This was causing upgrade problems. Specifically, in certain bridge topologies, if there was a manager set force-reload-kmod would fail. This is because the local port netdev would open in the in-band code with type "system", confusing the more important netdev_open() in iface_create(). Bug #15067. Signed-off-by: Ethan Jackson <ethan@nicira.com>
Diffstat (limited to 'ofproto')
-rw-r--r--ofproto/in-band.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/ofproto/in-band.c b/ofproto/in-band.c
index 3b98005f..1a08fcc0 100644
--- a/ofproto/in-band.c
+++ b/ofproto/in-band.c
@@ -464,7 +464,7 @@ in_band_create(struct ofproto *ofproto, const char *local_name,
int error;
*in_bandp = NULL;
- error = netdev_open(local_name, "system", &local_netdev);
+ error = netdev_open(local_name, "internal", &local_netdev);
if (error) {
VLOG_ERR("failed to initialize in-band control: cannot open "
"datapath local port %s (%s)", local_name, strerror(error));