diff options
author | Ben Pfaff <blp@nicira.com> | 2013-01-24 13:56:10 -0800 |
---|---|---|
committer | Ben Pfaff <blp@nicira.com> | 2013-02-01 14:26:51 -0800 |
commit | a6b112a8b31fdf56a73cb539c0ab41672fc71712 (patch) | |
tree | b096d14019d1aff13bb5ed3cb4f819f8991e1ca9 /lib | |
parent | 316bd0f8229ec252ce714ca2ece8367a49d929c3 (diff) |
ofp-util: Rename ofputil_port_from_string() variable to avoid hiding param.
This function has a parameter 's' and a local variable 's', so rename the
local variable to reduce confusion.
Found by Coverity.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Ethan Jackson <ethan@nicira.com>
Diffstat (limited to 'lib')
-rw-r--r-- | lib/ofp-util.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/lib/ofp-util.c b/lib/ofp-util.c index c66cd400..40983504 100644 --- a/lib/ofp-util.c +++ b/lib/ofp-util.c @@ -4115,14 +4115,14 @@ ofputil_port_from_string(const char *s, uint16_t *portp) *portp = port32; return true; } else if (port32 <= OFPP_LAST_RESV) { - struct ds s; + struct ds msg; - ds_init(&s); - ofputil_format_port(port32, &s); + ds_init(&msg); + ofputil_format_port(port32, &msg); VLOG_WARN_ONCE("referring to port %s as %u is deprecated for " "compatibility with future versions of OpenFlow", - ds_cstr(&s), port32); - ds_destroy(&s); + ds_cstr(&msg), port32); + ds_destroy(&msg); *portp = port32; return true; |