diff options
| author | Ben Pfaff <blp@nicira.com> | 2010-04-14 10:49:34 -0700 |
|---|---|---|
| committer | Ben Pfaff <blp@nicira.com> | 2010-04-14 17:01:58 -0700 |
| commit | 2c5d1389238951aa3c8a7382a39dc93033733120 (patch) | |
| tree | f02df883e8847227812ef4bcdbb9a99d4642628b /include | |
| parent | 2b1a27a1f834fd5f02cd1c376769bf5450805983 (diff) | |
ofproto: Use original in_port for executing NXAST_RESUBMIT actions.
If NXAST_RESUBMIT adopts the replacement in_port for executing actions,
then OFPP_NORMAL will believe that traffic originated from whatever port
that is. This seems unlikely to ever be useful and in fact breaks
applications that use NXAST_RESUBMIT for two-stage ACLs.
Bug #2644.
Diffstat (limited to 'include')
| -rw-r--r-- | include/openflow/nicira-ext.h | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h index 535cfc3a..17d86a86 100644 --- a/include/openflow/nicira-ext.h +++ b/include/openflow/nicira-ext.h @@ -61,14 +61,16 @@ enum nx_action_subtype { /* Searches the flow table again, using a flow that is slightly modified * from the original lookup: * - * - The flow's in_port is changed to that specified in the 'in_port' - * member of struct nx_action_resubmit. + * - The 'in_port' member of struct nx_action_resubmit is used as the + * flow's in_port. * * - If NXAST_RESUBMIT is preceded by actions that affect the flow * (e.g. OFPAT_SET_VLAN_VID), then the flow is updated with the new * values. * - * If the modified flow matches in the flow table, then the corresponding + * Following the lookup, the original in_port is restored. + * + * If the modified flow matched in the flow table, then the corresponding * actions are executed, except that NXAST_RESUBMIT actions found in the * secondary set of actions are ignored. Afterward, actions following * NXAST_RESUBMIT in the original set of actions, if any, are executed; any |