datapath: Use unicast Netlink sockets for upcalls.

Currently we publish several multicast groups for upcalls and let
userspace sockets subscribe to them.  The benefit of this is mostly
that userspace is the one doing the subscription - the actual
multicast capability is not currently used and probably wouldn't be
even if we moved to a multiprocess model.  Despite the convenience,
multicast sockets have a number of disadvantages, primarily that
we only have a limited number of them so there could be collisions.
In addition, unicast sockets give additional flexibility to userspace
by allowing every object to potentially have a different socket
chosen by userspace for upcalls.  Finally, any future optimizations
for upcalls to reduce copying will likely not be compatible with
multicast anyways so disallowing it potentially simplifies things.

We also never unregistered the multicast groups registered for upcalls
and leaked them on module unload.  As a side effect, this solves that
problem.

Signed-off-by: Jesse Gross <jesse@nicira.com>
Acked-by: Ben Pfaff <blp@nicira.com>

1 files changed, 1 insertions, 0 deletions

diff --git a/datapath/flow.h b/datapath/flow.h
index 3590a7df..ae12fe4d 100644
--- a/datapath/flow.h
+++ b/datapath/flow.h
@@ -81,6 +81,7 @@ struct sw_flow {
 	struct rcu_head rcu;
 	struct hlist_node  hash_node;
 	u32 hash;
+	u32 upcall_pid;
 
 	struct sw_flow_key key;
 	struct sw_flow_actions __rcu *sf_acts;