diff options
author | Ben Pfaff <blp@nicira.com> | 2011-04-15 09:31:36 -0700 |
---|---|---|
committer | Ben Pfaff <blp@nicira.com> | 2011-04-18 10:26:17 -0700 |
commit | 858f285284634a2933079cc6e68cc088c81cbe1d (patch) | |
tree | 0fca48be0096a115ba5e2630c1810cdccc8e8d77 /AUTHORS | |
parent | abf754896ee64d9a0319e70388afbcc177b3f9bd (diff) |
Fix calls to ctype functions.
The ctype functions often need casts to be fully C standards compliant.
Here's the full explanation that I used to post to comp.lang.c from time
to time when the issue came up:
With the to*() and is*() functions, you should be careful to cast
`char' arguments to `unsigned char' before calling them. Type `char'
may be signed or unsigned, depending on your compiler or its
configuration. If `char' is signed, then some characters have
negative values; however, the arguments to is*() and to*() functions
must be nonnegative (or EOF). Casting to `unsigned char' fixes this
problem by forcing the character to the corresponding positive value.
This fixes the following warnings from some version of GCC:
lib/ofp-parse.c:828: warning: array subscript has type 'char'
lib/ofp-print.c:617: warning: array subscript has type 'char'
Reported-by: YAMAMOTO Takashi <yamamoto@valinux.co.jp>
Diffstat (limited to 'AUTHORS')
-rw-r--r-- | AUTHORS | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -80,6 +80,7 @@ Stephen Hemminger shemminger@vyatta.com Takayuki HAMA t-hama@cb.jp.nec.com Teemu Koponen koponen@nicira.com Vishal Swarankar vishal.swarnkar@gmail.com +YAMAMOTO Takashi yamamoto@valinux.co.jp Yongqiang Liu liuyq7809@gmail.com kk yap yapkke@stanford.edu |