diff options
| author | Ben Pfaff <blp@nicira.com> | 2012-11-29 09:32:28 -0800 |
|---|---|---|
| committer | Ben Pfaff <blp@nicira.com> | 2012-11-29 12:53:32 -0800 |
| commit | 64e2748def0682dd1022b400b28c41f539cc523b (patch) | |
| tree | 2401227fbdddbd9b04031127a2273ed1d5265fc4 /AUTHORS | |
| parent | 8d45e9383bccf0799883a3b7f627a32a14a76a46 (diff) | |
bond: Fix segfault sending learning packets with LACP disabled.
It is essentially an invalid configuration to disable LACP but request TCP
balancing: in this configuration, the bond drops all packets. But
may_send_learning_packets() would still indicate that learning packets
should be sent, so bond_compose_learning_packet() would try to choose an
output slave for those packets, which would be NULL (because all packets
are dropped), which would cause a segfault upon dereference.
This commit fixes the problem by making may_send_learning_packets() no
longer indicate that learning packets should be sent.
I tested this issue by modifying bond_should_send_learning_packets() to
always return true if may_send_learning_packets() returns true, and then
introducing the invalid configuration described above. Without this comit,
ovs-vswitchd segfaults quickly; with this commit, it does not.
Bug #14090.
Reported-by: Kiran Shanbhog <kiran@vmware.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
Diffstat (limited to 'AUTHORS')
| -rw-r--r-- | AUTHORS | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -133,6 +133,7 @@ Jeongkeun Lee jklee@hp.com Joan Cirer joan@ev0.net John Galgay john@galgay.net Kevin Mancuso kevin.mancuso@rackspace.com +Kiran Shanbhog kiran@vmware.com Kirill Kabardin Koichi Yagishita yagishita.koichi@jrc.co.jp Konstantin Khorenko khorenko@openvz.org |