diff options
author | Ben Pfaff <blp@nicira.com> | 2012-01-31 09:39:28 -0800 |
---|---|---|
committer | Ben Pfaff <blp@nicira.com> | 2012-01-31 13:08:12 -0800 |
commit | cfc9268cabf32b5a70cc27988961aa238b8d1a27 (patch) | |
tree | af42dcff6cf2428f98cc9f214b0928c78c750cff | |
parent | 30c42b95a67a00faf1b8734d5a9a0bcad6556d07 (diff) |
sflow_agent: Use snprintf() in place of sprintf().
These functions use sprintf() into a 1000-byte buffer. It appears to me
that the strings they format are either short, fixed-length strings or the
output of strerror(), neither of which should ordinarily overflow.
However, using snprintf() cannot hurt.
Launchpad bug #914160.
Reported-by: Matthias Klose <doko@ubuntu.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
-rw-r--r-- | lib/sflow_agent.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/sflow_agent.c b/lib/sflow_agent.c index b0209586..f55e6d44 100644 --- a/lib/sflow_agent.c +++ b/lib/sflow_agent.c @@ -453,7 +453,7 @@ void sfl_agent_resetReceiver(SFLAgent *agent, SFLReceiver *receiver) void sfl_agent_error(SFLAgent *agent, char *modName, char *msg) { char errm[MAX_ERRMSG_LEN]; - sprintf(errm, "sfl_agent_error: %s: %s\n", modName, msg); + snprintf(errm, sizeof errm, "sfl_agent_error: %s: %s\n", modName, msg); if(agent->errorFn) (*agent->errorFn)(agent->magic, agent, errm); else { fprintf(stderr, "%s\n", errm); @@ -469,7 +469,7 @@ void sfl_agent_error(SFLAgent *agent, char *modName, char *msg) void sfl_agent_sysError(SFLAgent *agent, char *modName, char *msg) { char errm[MAX_ERRMSG_LEN]; - sprintf(errm, "sfl_agent_sysError: %s: %s (errno = %d - %s)\n", modName, msg, errno, strerror(errno)); + snprintf(errm, sizeof errm, "sfl_agent_sysError: %s: %s (errno = %d - %s)\n", modName, msg, errno, strerror(errno)); if(agent->errorFn) (*agent->errorFn)(agent->magic, agent, errm); else { fprintf(stderr, "%s\n", errm); |