aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBen Pfaff <blp@nicira.com>2012-03-28 14:02:57 -0700
committerBen Pfaff <blp@nicira.com>2012-03-28 16:17:05 -0700
commit2eb053125001b1d663e3e3692af9450648eff9b6 (patch)
tree801ae0577282cb9836fe4a8374bea37e82351dc0
parent4c1b8eecda77f8d1a2a500b3a16d6a212bd3c80a (diff)
ovsdb-idl: Fix memory leak writing synthetic rows in ovsdb_idl_txn_write().
This could cause a slow but steady memory leak in ovs-vswitchd. Found by valgrind. Signed-off-by: Ben Pfaff <blp@nicira.com>
-rw-r--r--lib/ovsdb-idl.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
index 19ae16fe..5ad3f5cd 100644
--- a/lib/ovsdb-idl.c
+++ b/lib/ovsdb-idl.c
@@ -1,4 +1,4 @@
-/* Copyright (c) 2009, 2010, 2011 Nicira Networks.
+/* Copyright (c) 2009, 2010, 2011, 2012 Nicira Networks.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -1718,6 +1718,7 @@ ovsdb_idl_txn_write(const struct ovsdb_idl_row *row_,
size_t column_idx;
if (ovsdb_idl_row_is_synthetic(row)) {
+ ovsdb_datum_destroy(datum, &column->type);
return;
}