diff options
| author | Ben Pfaff <blp@nicira.com> | 2010-03-25 11:34:01 -0700 |
|---|---|---|
| committer | Ben Pfaff <blp@nicira.com> | 2010-03-25 11:34:01 -0700 |
| commit | ea8cd10d2934586158734d31300f86eca381cc7a (patch) | |
| tree | a1efeaf34b423f1c3ec8005825a95b9ab9a082ad | |
| parent | 635670982103d24c4e574ddb5699b26864b2320d (diff) | |
timeval: Always log true poll interval instead of rounding off.
This code triggers when a trip through the process's main loop takes much
longer than expected. The code for calculating the expected time rounds
down to a maximum of 10000 ms to avoid overflow. But there is no reason
that the correct time should not be displayed in the log message, and
furthermore displaying the correct time may help tracking down the
underlying issue, since it lets the administrator find out exactly when
the trip through the main loop started. So this commit displays the exact
time without rounding down.
| -rw-r--r-- | lib/timeval.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/timeval.c b/lib/timeval.c index 5e423875..ab564a12 100644 --- a/lib/timeval.c +++ b/lib/timeval.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2008, 2009 Nicira Networks. + * Copyright (c) 2008, 2009, 2010 Nicira Networks. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -317,10 +317,10 @@ log_poll_interval(long long int last_wakeup, const struct rusage *last_rusage) struct rusage rusage; getrusage(RUSAGE_SELF, &rusage); - VLOG_WARN("%u ms poll interval (%lld ms user, %lld ms system) " + VLOG_WARN("%lld ms poll interval (%lld ms user, %lld ms system) " "is over %u times the weighted mean interval %u ms " "(%u samples)", - (interval + 8) / 16, + now - last_wakeup, timeval_diff_msec(&rusage.ru_utime, &last_rusage->ru_utime), timeval_diff_msec(&rusage.ru_stime, &last_rusage->ru_stime), interval / mean_interval, |