diff options
| author | Joe Stringer <joestringer@nicira.com> | 2014-12-03 12:57:02 -0800 |
|---|---|---|
| committer | Joe Stringer <joestringer@nicira.com> | 2014-12-12 12:34:58 +1300 |
| commit | bff6067904172b6f5034437e97f89598dbf41529 (patch) | |
| tree | eb4a05587d6130abe324983a28688654451d34a9 | |
| parent | 36673528f8a02a0becc1781bb529c60367cb08d5 (diff) | |
dpif: Don't initialize output UFID in dpif_flow_get().
The UFID parameter to dpif_flow_get() is optional, but the current
implementation dereferences it to initialize part of the output flow.
This field is filled in by the dpif implementation, so don't initialize
it here.
This does not fix any existing bug because every caller currently passes
in a UFID. The next patch will introduce the first call to
dpif_flow_get() that doesn't provide a UFID, which would break without
this change.
Signed-off-by: Joe Stringer <joestringer@nicira.com>
Acked-by: Ben Pfaff <blp@nicira.com>
| -rw-r--r-- | lib/dpif.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/lib/dpif.c b/lib/dpif.c index 50a7cc196..87954ed3b 100644 --- a/lib/dpif.c +++ b/lib/dpif.c @@ -893,7 +893,6 @@ dpif_flow_get(struct dpif *dpif, op.u.flow_get.flow = flow; op.u.flow_get.flow->key = key; op.u.flow_get.flow->key_len = key_len; - op.u.flow_get.flow->ufid = *ufid; opp = &op; dpif_operate(dpif, &opp, 1); |