diff options
| author | Hongbo Zhang <hongbo.zhang@linaro.org> | 2016-02-23 17:25:12 +0800 |
|---|---|---|
| committer | Maxim Uvarov <maxim.uvarov@linaro.org> | 2016-03-01 18:04:47 +0300 |
| commit | 50333e89b6c35edfa1221a4fbb74fc34bea6865d (patch) | |
| tree | f0a04f0837d4e48321ef4c19090b19ec7bc9a1b6 /platform/linux-generic/arch/x86 | |
| parent | 188a76d2f84a943ad59de6e5dc1d5c9f25dd2ac2 (diff) | |
linux-generic: fix usage of function strncpy
This is for https://bugs.linaro.org/show_bug.cgi?id=2030:
"Memory - illegal accesses (BUFFER_SIZE_WARNING)
Calling strncpy with a maximum size argument of 128 bytes on destination
array "sysinfo->model_str[id]" of size 128 bytes might leave the
destination string unterminated."
In fact in the following code there is operation like this:
sysinfo->model_str[id][len - 1] = 0
to handle the last character of string, but is is also good to eliminate
this coding warning.
Signed-off-by: Hongbo Zhang <hongbo.zhang@linaro.org>
Reviewed-by: Mike Holmes <mike.holmes@linaro.org>
Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
Diffstat (limited to 'platform/linux-generic/arch/x86')
| -rw-r--r-- | platform/linux-generic/arch/x86/odp_sysinfo_parse.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/platform/linux-generic/arch/x86/odp_sysinfo_parse.c b/platform/linux-generic/arch/x86/odp_sysinfo_parse.c index 816629dfa..2ef49e434 100644 --- a/platform/linux-generic/arch/x86/odp_sysinfo_parse.c +++ b/platform/linux-generic/arch/x86/odp_sysinfo_parse.c @@ -21,7 +21,7 @@ int odp_cpuinfo_parser(FILE *file, odp_system_info_t *sysinfo) if (pos) { pos = strchr(str, ':'); strncpy(sysinfo->model_str[id], pos + 2, - sizeof(sysinfo->model_str[id])); + sizeof(sysinfo->model_str[id]) - 1); pos = strchr(sysinfo->model_str[id], '@'); *(pos - 1) = '\0'; |