diff options
| author | Janne Peltonen <janne.peltonen@nokia.com> | 2022-03-11 17:16:45 +0200 |
|---|---|---|
| committer | Matias Elo <matias.elo@nokia.com> | 2022-04-13 11:21:01 +0300 |
| commit | 9ccb853815dcb77b4f802e2bf6a8dd919fb134f6 (patch) | |
| tree | 03f6bb511985d14178b7978ad79c3bb1475b4f26 /platform/linux-generic/arch/aarch64 | |
| parent | cf4e50baba3ca506651381f66c62fe8fd99f5d0d (diff) | |
api: crypto: deprecate odp_crypto_operation()
Depracate odp_crypto_operation() and the associated data structures
and the completion event. The odp_crypto_operation() function is a bit
problematic since it can be synchronous or asynchronous on per-packet
basis without application having control on it. Uncontrolled sync versus
async behaviour can have adverse effects on packet ordering and
application design in general. The function is also somewhat redundant
with the newer odp_crypto_op() and odp_crypto_op_enq() functions that
provide explicit control on the crypto operation completion behavior.
Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com>
Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com>
Reviewed-by: Anoob Joseph <anoobj@marvell.com>
Diffstat (limited to 'platform/linux-generic/arch/aarch64')
| -rw-r--r-- | platform/linux-generic/arch/aarch64/odp_crypto_armv8.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/platform/linux-generic/arch/aarch64/odp_crypto_armv8.c b/platform/linux-generic/arch/aarch64/odp_crypto_armv8.c index 20be1393a..4d46846ce 100644 --- a/platform/linux-generic/arch/aarch64/odp_crypto_armv8.c +++ b/platform/linux-generic/arch/aarch64/odp_crypto_armv8.c @@ -694,9 +694,7 @@ int odp_crypto_session_destroy(odp_crypto_session_t session) return 0; } -/* - * Shim function around packet operation, can be used by other implementations. - */ +#if ODP_DEPRECATED_API int odp_crypto_operation(odp_crypto_op_param_t *param, odp_bool_t *posted, @@ -751,6 +749,7 @@ odp_crypto_operation(odp_crypto_op_param_t *param, return 0; } +#endif int _odp_crypto_init_global(void) { @@ -831,6 +830,7 @@ int _odp_crypto_term_local(void) return 0; } +#if ODP_DEPRECATED_API odp_crypto_compl_t odp_crypto_compl_from_event(odp_event_t ev) { /* This check not mandated by the API specification */ @@ -867,6 +867,7 @@ uint64_t odp_crypto_compl_to_u64(odp_crypto_compl_t hdl) { return _odp_pri(hdl); } +#endif /* ODP_DEPRECATED_API */ void odp_crypto_session_param_init(odp_crypto_session_param_t *param) { |