diff options
| author | Janne Peltonen <janne.peltonen@nokia.com> | 2022-04-19 12:56:51 +0300 |
|---|---|---|
| committer | Petri Savolainen <petri.savolainen@nokia.com> | 2022-04-20 09:27:15 +0300 |
| commit | 12d3afa2da36da8d268cce1dd6124bf6529826f6 (patch) | |
| tree | e691a39b631e257b0451cdb093247d619b99b4af /platform/linux-generic/arch/aarch64 | |
| parent | 996090fd59593e0eb91a44a4debf678bfab91f40 (diff) | |
linux_gen: remove crypto error from packet error flags
Remove the unnecessary crypto_err parse flag from packet header.
odp_packet_has_error() is supposed to indicate parse errors not crypto
processing errors, which are indicated through odp_crypto_result_t.
Remove the flag and its setting in crypto implementations as the flag
is not needed and may cause subtle API spec violations.
Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com>
Reviewed-by: Anoob Joseph <anoobj@marvell.com>
Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com>
Diffstat (limited to 'platform/linux-generic/arch/aarch64')
| -rw-r--r-- | platform/linux-generic/arch/aarch64/odp_crypto_armv8.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/platform/linux-generic/arch/aarch64/odp_crypto_armv8.c b/platform/linux-generic/arch/aarch64/odp_crypto_armv8.c index 4d46846ce..89d227e32 100644 --- a/platform/linux-generic/arch/aarch64/odp_crypto_armv8.c +++ b/platform/linux-generic/arch/aarch64/odp_crypto_armv8.c @@ -724,7 +724,6 @@ odp_crypto_operation(odp_crypto_op_param_t *param, * We cannot fail since odp_crypto_op() has already processed * the packet. Let's indicate error in the result instead. */ - packet_hdr(out_pkt)->p.flags.crypto_err = 1; packet_result.ok = false; } @@ -916,8 +915,6 @@ int crypto_int(odp_packet_t pkt_in, odp_crypto_generic_session_t *session; odp_bool_t allocated = false; odp_packet_t out_pkt = *pkt_out; - odp_packet_hdr_t *pkt_hdr; - odp_bool_t ok; session = (odp_crypto_generic_session_t *)(intptr_t)param->session; @@ -959,11 +956,9 @@ int crypto_int(odp_packet_t pkt_in, } /* Invoke the crypto function */ - ok = session->func(out_pkt, param, session); + (void)session->func(out_pkt, param, session); packet_subtype_set(out_pkt, ODP_EVENT_PACKET_CRYPTO); - pkt_hdr = packet_hdr(out_pkt); - pkt_hdr->p.flags.crypto_err = !ok; /* Synchronous, simply return results */ *pkt_out = out_pkt; |