diff options
| author | Janne Peltonen <janne.peltonen@nokia.com> | 2020-06-08 17:23:14 +0300 |
|---|---|---|
| committer | Petri Savolainen <petri.savolainen@nokia.com> | 2020-06-11 11:07:58 +0300 |
| commit | 6c0ba00c10a49dec8cfdf007dfd60f94edb493ab (patch) | |
| tree | 8bbe18ceacc1fd0b27b425394a1677da8061ebb5 /helper | |
| parent | 57a0ffefe171a1a14005a8327be645a82159f199 (diff) | |
helper: do not ignore the return value of odp_pool_destroy()
Either check the return value of odp_pool_destroy() or explicitly cast it
to void to silence complaints from a static analyzer.
Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com>
Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com>
Diffstat (limited to 'helper')
| -rw-r--r-- | helper/cuckootable.c | 8 | ||||
| -rw-r--r-- | helper/iplookuptable.c | 2 |
2 files changed, 7 insertions, 3 deletions
diff --git a/helper/cuckootable.c b/helper/cuckootable.c index 237c2f297..47dd90b6c 100644 --- a/helper/cuckootable.c +++ b/helper/cuckootable.c @@ -260,7 +260,11 @@ odph_cuckoo_table_create( pool = odp_pool_lookup(pool_name); if (pool != ODP_POOL_INVALID) - odp_pool_destroy(pool); + if (odp_pool_destroy(pool)) { + odp_shm_free(shm_tbl); + ODPH_DBG("failed to destroy pre-existing pool\n"); + return NULL; + } odp_pool_param_init(¶m); param.type = ODP_POOL_BUFFER; @@ -285,7 +289,7 @@ odph_cuckoo_table_create( queue = odp_queue_create(queue_name, &qparam); if (queue == ODP_QUEUE_INVALID) { ODPH_DBG("failed to create free_slots queue\n"); - odp_pool_destroy(pool); + (void)odp_pool_destroy(pool); odp_shm_free(shm_tbl); return NULL; } diff --git a/helper/iplookuptable.c b/helper/iplookuptable.c index c02ee5415..eacfcf5f8 100644 --- a/helper/iplookuptable.c +++ b/helper/iplookuptable.c @@ -150,7 +150,7 @@ cache_destroy(odph_iplookup_table_impl *impl) sprintf( pool_name, "%s_%d_%d", impl->name, i, count); - odp_pool_destroy(odp_pool_lookup(pool_name)); + (void)odp_pool_destroy(odp_pool_lookup(pool_name)); } } } |