aboutsummaryrefslogtreecommitdiff
path: root/py/repl.c
diff options
context:
space:
mode:
authorArtyom Skrobov <tyomitch@gmail.com>2021-04-03 16:56:02 -0400
committerDamien George <damien@micropython.org>2021-05-02 23:11:14 +1000
commitca35c0059c8895839809f3e11873f96fc8cb4ab5 (patch)
tree08b617efd0be3436f9caa264f0ee3787360a3167 /py/repl.c
parent7556e01f14bb9f0ae32eff1d191985d302f1183e (diff)
py/repl: Autocomplete builtin modules.
Doing "import <tab>" will now complete/list built-in modules. Originally at adafruit#4548 and adafruit#4608 Signed-off-by: Artyom Skrobov <tyomitch@gmail.com>
Diffstat (limited to 'py/repl.c')
-rw-r--r--py/repl.c34
1 files changed, 22 insertions, 12 deletions
diff --git a/py/repl.c b/py/repl.c
index c8bb715e9..57bc21eff 100644
--- a/py/repl.c
+++ b/py/repl.c
@@ -26,6 +26,7 @@
#include <string.h>
#include "py/obj.h"
+#include "py/objmodule.h"
#include "py/runtime.h"
#include "py/builtin.h"
#include "py/repl.h"
@@ -144,10 +145,16 @@ bool mp_repl_continue_with_input(const char *input) {
}
STATIC bool test_qstr(mp_obj_t obj, qstr name) {
- // try object member
- mp_obj_t dest[2];
- mp_load_method_protected(obj, name, dest, true);
- return dest[0] != MP_OBJ_NULL;
+ if (obj) {
+ // try object member
+ mp_obj_t dest[2];
+ mp_load_method_protected(obj, name, dest, true);
+ return dest[0] != MP_OBJ_NULL;
+ } else {
+ // try builtin module
+ return mp_map_lookup((mp_map_t *)&mp_builtin_module_map,
+ MP_OBJ_NEW_QSTR(name), MP_MAP_LOOKUP);
+ }
}
STATIC const char *find_completions(const char *s_start, size_t s_len,
@@ -274,6 +281,12 @@ size_t mp_repl_autocomplete(const char *str, size_t len, const mp_print_t *print
++str;
}
+ // after "import", suggest built-in modules
+ static const char import_str[] = "import ";
+ if (len >= 7 && !memcmp(org_str, import_str, 7)) {
+ obj = MP_OBJ_NULL;
+ }
+
// look for matches
size_t match_len;
qstr q_first, q_last;
@@ -282,21 +295,18 @@ size_t mp_repl_autocomplete(const char *str, size_t len, const mp_print_t *print
// nothing found
if (q_first == 0) {
- if (s_len == 0) {
- *compl_str = " ";
- return 4;
- }
// If there're no better alternatives, and if it's first word
// in the line, try to complete "import".
- if (s_start == org_str) {
- static const char import_str[] = "import ";
+ if (s_start == org_str && s_len > 0) {
if (memcmp(s_start, import_str, s_len) == 0) {
*compl_str = import_str + s_len;
return sizeof(import_str) - 1 - s_len;
}
}
-
- return 0;
+ if (q_first == 0) {
+ *compl_str = " ";
+ return s_len ? 0 : 4;
+ }
}
// 1 match found, or multiple matches with a common prefix