aboutsummaryrefslogtreecommitdiff
path: root/py/objrange.c
diff options
context:
space:
mode:
authorDamien George <damien.p.george@gmail.com>2017-04-05 10:50:26 +1000
committerDamien George <damien.p.george@gmail.com>2017-04-05 10:50:26 +1000
commitde9b53695d1bf8d7580e8371e4bc502a29334e6f (patch)
treeb2a713516bad10df36487498fdfdf88988a1cb85 /py/objrange.c
parent546ef301a12ccd6015137964637983432c64d11f (diff)
py: Raise a ValueError if range() step is zero.
Following CPython. Otherwise one gets either an infinite loop (if code is optimised by the uPy compiler) or possibly a divide-by-zero CPU exception.
Diffstat (limited to 'py/objrange.c')
-rw-r--r--py/objrange.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/py/objrange.c b/py/objrange.c
index 5bf0bc7a9..c78c53f11 100644
--- a/py/objrange.c
+++ b/py/objrange.c
@@ -105,8 +105,10 @@ STATIC mp_obj_t range_make_new(const mp_obj_type_t *type, size_t n_args, size_t
o->start = mp_obj_get_int(args[0]);
o->stop = mp_obj_get_int(args[1]);
if (n_args == 3) {
- // TODO check step is non-zero
o->step = mp_obj_get_int(args[2]);
+ if (o->step == 0) {
+ mp_raise_ValueError("zero step");
+ }
}
}