aboutsummaryrefslogtreecommitdiff
path: root/py/objgenerator.c
diff options
context:
space:
mode:
authorDamien George <damien.p.george@gmail.com>2018-06-29 16:32:58 +1000
committerDamien George <damien.p.george@gmail.com>2018-07-02 15:30:57 +1000
commitb488a4a8480533a6a3c9468c2f8bd359c94d4d02 (patch)
tree709b6ca9495c832856f54e03bc4db3055c861cb0 /py/objgenerator.c
parent8f86fbfd6c34a4d03f2bd62e9dc1ff59c236b037 (diff)
py/objgenerator: Eliminate need for mp_obj_gen_wrap wrapper instances.
For generating functions there is no need to wrap the bytecode function in a generator wrapper instance. Instead the type of the bytecode function can be changed to mp_type_gen_wrap. This reduces code size and saves a block of GC heap RAM for each generator.
Diffstat (limited to 'py/objgenerator.c')
-rw-r--r--py/objgenerator.c17
1 files changed, 2 insertions, 15 deletions
diff --git a/py/objgenerator.c b/py/objgenerator.c
index a2ad490d6..8b898c937 100644
--- a/py/objgenerator.c
+++ b/py/objgenerator.c
@@ -37,11 +37,6 @@
/******************************************************************************/
/* generator wrapper */
-typedef struct _mp_obj_gen_wrap_t {
- mp_obj_base_t base;
- mp_obj_t *fun;
-} mp_obj_gen_wrap_t;
-
typedef struct _mp_obj_gen_instance_t {
mp_obj_base_t base;
mp_obj_dict_t *globals;
@@ -49,9 +44,8 @@ typedef struct _mp_obj_gen_instance_t {
} mp_obj_gen_instance_t;
STATIC mp_obj_t gen_wrap_call(mp_obj_t self_in, size_t n_args, size_t n_kw, const mp_obj_t *args) {
- mp_obj_gen_wrap_t *self = MP_OBJ_TO_PTR(self_in);
- mp_obj_fun_bc_t *self_fun = (mp_obj_fun_bc_t*)self->fun;
- assert(self_fun->base.type == &mp_type_fun_bc);
+ // A generating function is just a bytecode function with type mp_type_gen_wrap
+ mp_obj_fun_bc_t *self_fun = MP_OBJ_TO_PTR(self_in);
// bytecode prelude: get state size and exception stack size
size_t n_state = mp_decode_uint_value(self_fun->bytecode);
@@ -76,13 +70,6 @@ const mp_obj_type_t mp_type_gen_wrap = {
.unary_op = mp_generic_unary_op,
};
-mp_obj_t mp_obj_new_gen_wrap(mp_obj_t fun) {
- mp_obj_gen_wrap_t *o = m_new_obj(mp_obj_gen_wrap_t);
- o->base.type = &mp_type_gen_wrap;
- o->fun = MP_OBJ_TO_PTR(fun);
- return MP_OBJ_FROM_PTR(o);
-}
-
/******************************************************************************/
/* generator instance */