diff options
| author | Jon Bjarni Bjarnason <jbbjarnason@gmail.com> | 2022-02-16 11:44:17 -0500 |
|---|---|---|
| committer | Damien George <damien@micropython.org> | 2022-04-11 15:26:47 +1000 |
| commit | 919f696ad254bcc39effe7ce7fddae8cf406c954 (patch) | |
| tree | 38a132ffc829eb7888009f72e547ecf2d30058af /extmod/modlwip.c | |
| parent | d3d862769ad9f1317702b921dda1912d9a673948 (diff) | |
extmod/modusocket: Implement optional socket.listen backlog argument.
This follows the CPython change: https://bugs.python.org/issue21455
Socket listen backlog defaults to 2 if not given, based on most bare metal
targets not having many resources for a large backlog. On UNIX it defaults
to SOMAXCONN or 128, whichever is less.
Diffstat (limited to 'extmod/modlwip.c')
| -rw-r--r-- | extmod/modlwip.c | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/extmod/modlwip.c b/extmod/modlwip.c index 8811742d6..e62d4e7e4 100644 --- a/extmod/modlwip.c +++ b/extmod/modlwip.c @@ -911,9 +911,14 @@ STATIC mp_obj_t lwip_socket_bind(mp_obj_t self_in, mp_obj_t addr_in) { } STATIC MP_DEFINE_CONST_FUN_OBJ_2(lwip_socket_bind_obj, lwip_socket_bind); -STATIC mp_obj_t lwip_socket_listen(mp_obj_t self_in, mp_obj_t backlog_in) { - lwip_socket_obj_t *socket = MP_OBJ_TO_PTR(self_in); - mp_int_t backlog = mp_obj_get_int(backlog_in); +STATIC mp_obj_t lwip_socket_listen(size_t n_args, const mp_obj_t *args) { + lwip_socket_obj_t *socket = MP_OBJ_TO_PTR(args[0]); + + mp_int_t backlog = 2; + if (n_args > 1) { + backlog = mp_obj_get_int(args[1]); + backlog = (backlog < 0) ? 0 : backlog; + } if (socket->pcb.tcp == NULL) { mp_raise_OSError(MP_EBADF); @@ -946,7 +951,7 @@ STATIC mp_obj_t lwip_socket_listen(mp_obj_t self_in, mp_obj_t backlog_in) { return mp_const_none; } -STATIC MP_DEFINE_CONST_FUN_OBJ_2(lwip_socket_listen_obj, lwip_socket_listen); +STATIC MP_DEFINE_CONST_FUN_OBJ_VAR_BETWEEN(lwip_socket_listen_obj, 1, 2, lwip_socket_listen); STATIC mp_obj_t lwip_socket_accept(mp_obj_t self_in) { lwip_socket_obj_t *socket = MP_OBJ_TO_PTR(self_in); |