diff options
| author | Ard Biesheuvel <ard.biesheuvel@linaro.org> | 2018-03-16 14:55:59 +0000 |
|---|---|---|
| committer | Ard Biesheuvel <ard.biesheuvel@linaro.org> | 2018-06-01 11:57:27 +0200 |
| commit | e3dc34956a641d3d6c2d32348ca53899eda4325e (patch) | |
| tree | c4bc3f7d4c19441d7111a3b4311cb174531eb11d /Silicon/Socionext/SynQuacer/Library | |
| parent | c9be7b11ea10d274c5921c14151a17f07d8f7593 (diff) | |
Silicon/SynQuacerPlatformFlashAccessLib: fix return value on no FVB found
If no suitable FVB protocol implementation is found to apply the capsule
update, and the last one we disregarded was ruled out because it has the
read-only attribute, we will exit the function returning EFI_SUCCESS
without assigning a value to *OutFvb, resulting in a crash when it
subsequently gets dereferenced. So set the correct value for Status for
that case.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Diffstat (limited to 'Silicon/Socionext/SynQuacer/Library')
| -rw-r--r-- | Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.c b/Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.c index fbb8f1f9..1af4abc1 100644 --- a/Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.c +++ b/Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.c @@ -99,6 +99,7 @@ GetFvbByAddress ( DEBUG ((DEBUG_INFO,
"%a: ignoring read-only FVB protocol implementation\n",
__FUNCTION__));
+ Status = EFI_NOT_FOUND;
continue;
}
|