diff options
author | Mukul Kumar Singh <msingh@apache.org> | 2018-05-08 18:11:33 +0530 |
---|---|---|
committer | Mukul Kumar Singh <msingh@apache.org> | 2018-05-08 18:11:33 +0530 |
commit | d72c16516184479e82a73d3e211e2883be779908 (patch) | |
tree | 5c170300d906beac22845d6db97b17a9f71f72d3 /hadoop-hdds/container-service/src/main/java/org/apache | |
parent | 7450583721757b8af2945ebd9be1a9efed11444c (diff) |
HDDS-23. Remove SCMNodeAddressList from SCMRegisterRequestProto. Contributed by Nanda Kumar.
Diffstat (limited to 'hadoop-hdds/container-service/src/main/java/org/apache')
4 files changed, 6 insertions, 16 deletions
diff --git a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/states/endpoint/RegisterEndpointTask.java b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/states/endpoint/RegisterEndpointTask.java index ca3bef0b35..42568e3ad3 100644 --- a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/states/endpoint/RegisterEndpointTask.java +++ b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/states/endpoint/RegisterEndpointTask.java @@ -99,8 +99,7 @@ public final class RegisterEndpointTask implements // TODO : Add responses to the command Queue. SCMRegisteredCmdResponseProto response = rpcEndPoint.getEndPoint() - .register(datanodeDetails.getProtoBufMessage(), - conf.getStrings(ScmConfigKeys.OZONE_SCM_NAMES)); + .register(datanodeDetails.getProtoBufMessage()); Preconditions.checkState(UUID.fromString(response.getDatanodeUUID()) .equals(datanodeDetails.getUuid()), "Unexpected datanode ID in the response."); diff --git a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/protocol/StorageContainerDatanodeProtocol.java b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/protocol/StorageContainerDatanodeProtocol.java index 43e7412aea..cb65727630 100644 --- a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/protocol/StorageContainerDatanodeProtocol.java +++ b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/protocol/StorageContainerDatanodeProtocol.java @@ -69,12 +69,11 @@ public interface StorageContainerDatanodeProtocol { /** * Register Datanode. * @param datanodeDetails - Datanode Details. - * @param scmAddresses - List of SCMs this datanode is configured to - * communicate. + * * @return SCM Command. */ - SCMRegisteredCmdResponseProto register(DatanodeDetailsProto datanodeDetails, - String[] scmAddresses) throws IOException; + SCMRegisteredCmdResponseProto register(DatanodeDetailsProto datanodeDetails) + throws IOException; /** * Send a container report. diff --git a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/protocolPB/StorageContainerDatanodeProtocolClientSideTranslatorPB.java b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/protocolPB/StorageContainerDatanodeProtocolClientSideTranslatorPB.java index 12fed1cd0f..13162de7d3 100644 --- a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/protocolPB/StorageContainerDatanodeProtocolClientSideTranslatorPB.java +++ b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/protocolPB/StorageContainerDatanodeProtocolClientSideTranslatorPB.java @@ -156,8 +156,7 @@ public class StorageContainerDatanodeProtocolClientSideTranslatorPB */ @Override public SCMRegisteredCmdResponseProto register( - DatanodeDetailsProto datanodeDetailsProto, - String[] scmAddresses) throws IOException { + DatanodeDetailsProto datanodeDetailsProto) throws IOException { SCMRegisterRequestProto.Builder req = SCMRegisterRequestProto.newBuilder(); req.setDatanodeDetails(datanodeDetailsProto); diff --git a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/protocolPB/StorageContainerDatanodeProtocolServerSideTranslatorPB.java b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/protocolPB/StorageContainerDatanodeProtocolServerSideTranslatorPB.java index 985b75acd6..25757aa345 100644 --- a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/protocolPB/StorageContainerDatanodeProtocolServerSideTranslatorPB.java +++ b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/protocolPB/StorageContainerDatanodeProtocolServerSideTranslatorPB.java @@ -68,15 +68,8 @@ public class StorageContainerDatanodeProtocolServerSideTranslatorPB public StorageContainerDatanodeProtocolProtos.SCMRegisteredCmdResponseProto register(RpcController controller, StorageContainerDatanodeProtocolProtos .SCMRegisterRequestProto request) throws ServiceException { - String[] addressArray = null; - - if (request.hasAddressList()) { - addressArray = request.getAddressList().getAddressListList() - .toArray(new String[0]); - } - try { - return impl.register(request.getDatanodeDetails(), addressArray); + return impl.register(request.getDatanodeDetails()); } catch (IOException e) { throw new ServiceException(e); } |