summaryrefslogtreecommitdiff
path: root/qa/evil-tests/src/test/java/org/elasticsearch/plugins/PluginManagerPermissionTests.java
blob: d5a07606e654039fc6879b9624eb9ed58fffc526 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
/*
 * Licensed to Elasticsearch under one or more contributor
 * license agreements. See the NOTICE file distributed with
 * this work for additional information regarding copyright
 * ownership. Elasticsearch licenses this file to you under
 * the Apache License, Version 2.0 (the "License"); you may
 * not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *    http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing,
 * software distributed under the License is distributed on an
 * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 * KIND, either express or implied.  See the License for the
 * specific language governing permissions and limitations
 * under the License.
 */

package org.elasticsearch.plugins;

import org.apache.lucene.util.LuceneTestCase;
import org.elasticsearch.Version;
import org.elasticsearch.common.cli.CliToolTestCase.CaptureOutputTerminal;
import org.elasticsearch.common.settings.Settings;
import org.elasticsearch.common.unit.TimeValue;
import org.elasticsearch.env.Environment;
import org.elasticsearch.test.ESTestCase;
import org.junit.Before;

import java.io.IOException;
import java.net.URL;
import java.nio.charset.Charset;
import java.nio.file.FileVisitResult;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.SimpleFileVisitor;
import java.nio.file.attribute.*;
import java.util.HashSet;
import java.util.Set;
import java.util.zip.ZipEntry;
import java.util.zip.ZipOutputStream;

import static java.nio.file.attribute.PosixFilePermission.*;
import static org.elasticsearch.common.settings.Settings.settingsBuilder;
import static org.elasticsearch.test.hamcrest.ElasticsearchAssertions.*;
import static org.hamcrest.Matchers.*;

// there are some lucene file systems that seem to cause problems (deleted files, dirs instead of files)
@LuceneTestCase.SuppressFileSystems("*")
public class PluginManagerPermissionTests extends ESTestCase {

    private String pluginName = "my-plugin";
    private CaptureOutputTerminal terminal = new CaptureOutputTerminal();
    private Environment environment;
    private boolean supportsPermissions;

    @Before
    public void setup() {
        Path tempDir = createTempDir();
        Settings.Builder settingsBuilder = settingsBuilder().put("path.home", tempDir);
        if (randomBoolean()) {
            settingsBuilder.put("path.plugins", createTempDir());
        }

        if (randomBoolean()) {
            settingsBuilder.put("path.conf", createTempDir());
        }

        environment = new Environment(settingsBuilder.build());

        supportsPermissions = tempDir.getFileSystem().supportedFileAttributeViews().contains("posix");
    }

    public void testThatUnaccessibleBinDirectoryAbortsPluginInstallation() throws Exception {
        assumeTrue("File system does not support permissions, skipping", supportsPermissions);

        URL pluginUrl = createPlugin(true, randomBoolean());

        Path binPath = environment.binFile().resolve(pluginName);
        Files.createDirectories(binPath);
        try {
            Files.setPosixFilePermissions(binPath, PosixFilePermissions.fromString("---------"));

            PluginManager pluginManager = new PluginManager(environment, pluginUrl, PluginManager.OutputMode.VERBOSE, TimeValue.timeValueSeconds(10));
            pluginManager.downloadAndExtract(pluginName, terminal, true);

            fail("Expected IOException but did not happen");
        } catch (IOException e) {
            assertFileNotExists(environment.pluginsFile().resolve(pluginName));
            assertFileNotExists(environment.configFile().resolve(pluginName));
            // exists, because of our weird permissions above
            assertDirectoryExists(environment.binFile().resolve(pluginName));

            assertThat(terminal.getTerminalOutput(), hasItem(containsString("Error copying bin directory ")));
        } finally {
            Files.setPosixFilePermissions(binPath, PosixFilePermissions.fromString("rwxrwxrwx"));
        }
    }

    public void testThatUnaccessiblePluginConfigDirectoryAbortsPluginInstallation() throws Exception {
        assumeTrue("File system does not support permissions, skipping", supportsPermissions);

        URL pluginUrl = createPlugin(randomBoolean(), true);

        Path path = environment.configFile().resolve(pluginName);
        Files.createDirectories(path);
        Files.createFile(path.resolve("my-custom-config.yaml"));
        Path binPath = environment.binFile().resolve(pluginName);
        Files.createDirectories(binPath);

        try {
            Files.setPosixFilePermissions(path.resolve("my-custom-config.yaml"), PosixFilePermissions.fromString("---------"));
            Files.setPosixFilePermissions(path, PosixFilePermissions.fromString("---------"));

            PluginManager pluginManager = new PluginManager(environment, pluginUrl, PluginManager.OutputMode.VERBOSE, TimeValue.timeValueSeconds(10));
            pluginManager.downloadAndExtract(pluginName, terminal, true);

            fail("Expected IOException but did not happen, terminal output was " + terminal.getTerminalOutput());
        } catch (IOException e) {
            assertFileNotExists(environment.pluginsFile().resolve(pluginName));
            assertFileNotExists(environment.binFile().resolve(pluginName));
            // exists, because of our weird permissions above
            assertDirectoryExists(environment.configFile().resolve(pluginName));

            assertThat(terminal.getTerminalOutput(), hasItem(containsString("Error copying config directory ")));
        } finally {
            Files.setPosixFilePermissions(path, PosixFilePermissions.fromString("rwxrwxrwx"));
            Files.setPosixFilePermissions(path.resolve("my-custom-config.yaml"), PosixFilePermissions.fromString("rwxrwxrwx"));
        }
    }

    // config/bin are not writable, but the plugin does not need to put anything into it
    public void testThatPluginWithoutBinAndConfigWorksEvenIfPermissionsAreWrong() throws Exception {
        assumeTrue("File system does not support permissions, skipping", supportsPermissions);

        URL pluginUrl = createPlugin(false, false);
        Path path = environment.configFile().resolve(pluginName);
        Files.createDirectories(path);
        Files.createFile(path.resolve("my-custom-config.yaml"));
        Path binPath = environment.binFile().resolve(pluginName);
        Files.createDirectories(binPath);

        try {
            Files.setPosixFilePermissions(path.resolve("my-custom-config.yaml"), PosixFilePermissions.fromString("---------"));
            Files.setPosixFilePermissions(path, PosixFilePermissions.fromString("---------"));
            Files.setPosixFilePermissions(binPath, PosixFilePermissions.fromString("---------"));

            PluginManager pluginManager = new PluginManager(environment, pluginUrl, PluginManager.OutputMode.VERBOSE, TimeValue.timeValueSeconds(10));
            pluginManager.downloadAndExtract(pluginName, terminal, true);
        } finally {
            Files.setPosixFilePermissions(binPath, PosixFilePermissions.fromString("rwxrwxrwx"));
            Files.setPosixFilePermissions(path, PosixFilePermissions.fromString("rwxrwxrwx"));
            Files.setPosixFilePermissions(path.resolve("my-custom-config.yaml"), PosixFilePermissions.fromString("rwxrwxrwx"));
        }

    }

    // plugins directory no accessible, should leave no other left over directories
    public void testThatNonWritablePluginsDirectoryLeavesNoLeftOver() throws Exception {
        assumeTrue("File system does not support permissions, skipping", supportsPermissions);

        URL pluginUrl = createPlugin(true, true);
        Files.createDirectories(environment.pluginsFile());

        try {
            Files.setPosixFilePermissions(environment.pluginsFile(), PosixFilePermissions.fromString("---------"));
            PluginManager pluginManager = new PluginManager(environment, pluginUrl, PluginManager.OutputMode.VERBOSE, TimeValue.timeValueSeconds(10));
            try {
                pluginManager.downloadAndExtract(pluginName, terminal, true);
                fail("Expected IOException due to read-only plugins/ directory");
            } catch (IOException e) {
                assertFileNotExists(environment.binFile().resolve(pluginName));
                assertFileNotExists(environment.configFile().resolve(pluginName));

                Files.setPosixFilePermissions(environment.pluginsFile(), PosixFilePermissions.fromString("rwxrwxrwx"));
                assertDirectoryExists(environment.pluginsFile());
                assertFileNotExists(environment.pluginsFile().resolve(pluginName));
            }
        } finally {
            Files.setPosixFilePermissions(environment.pluginsFile(), PosixFilePermissions.fromString("rwxrwxrwx"));
        }
    }

    public void testThatUnwriteableBackupFilesInConfigurationDirectoryAreReplaced() throws Exception {
        assumeTrue("File system does not support permissions, skipping", supportsPermissions);

        boolean pluginContainsExecutables = randomBoolean();
        URL pluginUrl = createPlugin(pluginContainsExecutables, true);
        Files.createDirectories(environment.configFile().resolve(pluginName));

        Path configFile = environment.configFile().resolve(pluginName).resolve("my-custom-config.yaml");
        Files.createFile(configFile);
        Path backupConfigFile = environment.configFile().resolve(pluginName).resolve("my-custom-config.yaml.new");
        Files.createFile(backupConfigFile);
        Files.write(backupConfigFile, "foo".getBytes(Charset.forName("UTF-8")));

        PluginManager pluginManager = new PluginManager(environment, pluginUrl, PluginManager.OutputMode.VERBOSE, TimeValue.timeValueSeconds(10));
        try {
            Files.setPosixFilePermissions(backupConfigFile, PosixFilePermissions.fromString("---------"));

            pluginManager.downloadAndExtract(pluginName, terminal, true);

            if (pluginContainsExecutables) {
                assertDirectoryExists(environment.binFile().resolve(pluginName));
            }
            assertDirectoryExists(environment.pluginsFile().resolve(pluginName));
            assertDirectoryExists(environment.configFile().resolve(pluginName));

            assertFileExists(backupConfigFile);
            Files.setPosixFilePermissions(backupConfigFile, PosixFilePermissions.fromString("rw-rw-rw-"));
            String content = new String(Files.readAllBytes(backupConfigFile), Charset.forName("UTF-8"));
            assertThat(content, is(not("foo")));
        } finally {
            Files.setPosixFilePermissions(backupConfigFile, PosixFilePermissions.fromString("rw-rw-rw-"));
        }
    }

    public void testThatConfigDirectoryBeingAFileAbortsInstallationAndDoesNotAccidentallyDeleteThisFile() throws Exception {
        assumeTrue("File system does not support permissions, skipping", supportsPermissions);

        Files.createDirectories(environment.configFile());
        Files.createFile(environment.configFile().resolve(pluginName));
        URL pluginUrl = createPlugin(randomBoolean(), true);

        PluginManager pluginManager = new PluginManager(environment, pluginUrl, PluginManager.OutputMode.VERBOSE, TimeValue.timeValueSeconds(10));

        try {
            pluginManager.downloadAndExtract(pluginName, terminal, true);
            fail("Expected plugin installation to fail, but didnt");
        } catch (IOException e) {
            assertFileExists(environment.configFile().resolve(pluginName));
            assertFileNotExists(environment.binFile().resolve(pluginName));
            assertFileNotExists(environment.pluginsFile().resolve(pluginName));
        }
    }

    public void testThatBinDirectoryBeingAFileAbortsInstallationAndDoesNotAccidentallyDeleteThisFile() throws Exception {
        assumeTrue("File system does not support permissions, skipping", supportsPermissions);

        Files.createDirectories(environment.binFile());
        Files.createFile(environment.binFile().resolve(pluginName));
        URL pluginUrl = createPlugin(true, randomBoolean());

        PluginManager pluginManager = new PluginManager(environment, pluginUrl, PluginManager.OutputMode.VERBOSE, TimeValue.timeValueSeconds(10));

        try {
            pluginManager.downloadAndExtract(pluginName, terminal, true);
            fail("Expected plugin installation to fail, but didnt");
        } catch (IOException e) {
            assertFileExists(environment.binFile().resolve(pluginName));
            assertFileNotExists(environment.configFile().resolve(pluginName));
            assertFileNotExists(environment.pluginsFile().resolve(pluginName));
        }
    }

    public void testConfigDirectoryOwnerGroupAndPermissions() throws IOException {
        assumeTrue("File system does not support permissions, skipping", supportsPermissions);
        URL pluginUrl = createPlugin(false, true);
        PluginManager pluginManager = new PluginManager(environment, pluginUrl, PluginManager.OutputMode.VERBOSE, TimeValue.timeValueSeconds(10));
        pluginManager.downloadAndExtract(pluginName, terminal, true);
        PosixFileAttributes parentFileAttributes = Files.getFileAttributeView(environment.configFile(), PosixFileAttributeView.class).readAttributes();
        Path configPath = environment.configFile().resolve(pluginName);
        PosixFileAttributes pluginConfigDirAttributes = Files.getFileAttributeView(configPath, PosixFileAttributeView.class).readAttributes();
        assertThat(pluginConfigDirAttributes.owner(), equalTo(parentFileAttributes.owner()));
        assertThat(pluginConfigDirAttributes.group(), equalTo(parentFileAttributes.group()));
        assertThat(pluginConfigDirAttributes.permissions(), equalTo(parentFileAttributes.permissions()));
        Path configFile = configPath.resolve("my-custom-config.yaml");
        PosixFileAttributes pluginConfigFileAttributes = Files.getFileAttributeView(configFile, PosixFileAttributeView.class).readAttributes();
        assertThat(pluginConfigFileAttributes.owner(), equalTo(parentFileAttributes.owner()));
        assertThat(pluginConfigFileAttributes.group(), equalTo(parentFileAttributes.group()));
        Set<PosixFilePermission> expectedFilePermissions = new HashSet<>();
        for (PosixFilePermission parentPermission : parentFileAttributes.permissions()) {
            switch(parentPermission) {
                case OWNER_EXECUTE:
                case GROUP_EXECUTE:
                case OTHERS_EXECUTE:
                    break;
                default:
                    expectedFilePermissions.add(parentPermission);
            }
        }
        assertThat(pluginConfigFileAttributes.permissions(), equalTo(expectedFilePermissions));
    }

    public void testBinDirectoryOwnerGroupAndPermissions() throws IOException {
        assumeTrue("File system does not support permissions, skipping", supportsPermissions);
        URL pluginUrl = createPlugin(true, false);
        PluginManager pluginManager = new PluginManager(environment, pluginUrl, PluginManager.OutputMode.VERBOSE, TimeValue.timeValueSeconds(10));
        pluginManager.downloadAndExtract(pluginName, terminal, true);
        PosixFileAttributes parentFileAttributes = Files.getFileAttributeView(environment.binFile(), PosixFileAttributeView.class).readAttributes();
        Path binPath = environment.binFile().resolve(pluginName);
        PosixFileAttributes pluginBinDirAttributes = Files.getFileAttributeView(binPath, PosixFileAttributeView.class).readAttributes();
        assertThat(pluginBinDirAttributes.owner(), equalTo(parentFileAttributes.owner()));
        assertThat(pluginBinDirAttributes.group(), equalTo(parentFileAttributes.group()));
        assertThat(pluginBinDirAttributes.permissions(), equalTo(parentFileAttributes.permissions()));
        Path executableFile = binPath.resolve("my-binary");
        PosixFileAttributes pluginExecutableFileAttributes = Files.getFileAttributeView(executableFile, PosixFileAttributeView.class).readAttributes();
        assertThat(pluginExecutableFileAttributes.owner(), equalTo(parentFileAttributes.owner()));
        assertThat(pluginExecutableFileAttributes.group(), equalTo(parentFileAttributes.group()));
        Set<PosixFilePermission> expectedFilePermissions = new HashSet<>();
        expectedFilePermissions.add(OWNER_EXECUTE);
        expectedFilePermissions.add(GROUP_EXECUTE);
        expectedFilePermissions.add(OTHERS_EXECUTE);
        for (PosixFilePermission parentPermission : parentFileAttributes.permissions()) {
            switch(parentPermission) {
                case OWNER_EXECUTE:
                case GROUP_EXECUTE:
                case OTHERS_EXECUTE:
                    break;
                default:
                    expectedFilePermissions.add(parentPermission);
            }
        }

        assertThat(pluginExecutableFileAttributes.permissions(), equalTo(expectedFilePermissions));
    }

    private URL createPlugin(boolean withBinDir, boolean withConfigDir) throws IOException {
        final Path structure = createTempDir().resolve("fake-plugin");
        PluginTestUtil.writeProperties(structure, "description", "fake desc",
                "version", "1.0",
                "elasticsearch.version", Version.CURRENT.toString(),
                "jvm", "true",
                "java.version", "1.7",
                "name", pluginName,
                "classname", pluginName);
        if (withBinDir) {
            // create bin dir
            Path binDir = structure.resolve("bin");
            Files.createDirectory(binDir);
            Files.setPosixFilePermissions(binDir, PosixFilePermissions.fromString("rwxr-xr-x"));

            // create executable
            Path executable = binDir.resolve("my-binary");
            Files.createFile(executable);
            Files.setPosixFilePermissions(executable, PosixFilePermissions.fromString("rw-r--r--"));
        }
        if (withConfigDir) {
            // create bin dir
            Path configDir = structure.resolve("config");
            Files.createDirectory(configDir);
            Files.setPosixFilePermissions(configDir, PosixFilePermissions.fromString("rwxr-xr-x"));

            // create config file
            Path configFile = configDir.resolve("my-custom-config.yaml");
            Files.createFile(configFile);
            Files.write(configFile, "my custom config content".getBytes(Charset.forName("UTF-8")));
            Files.setPosixFilePermissions(configFile, PosixFilePermissions.fromString("rw-r--r--"));
        }

        Path zip = createTempDir().resolve(structure.getFileName() + ".zip");
        try (ZipOutputStream stream = new ZipOutputStream(Files.newOutputStream(zip))) {
            Files.walkFileTree(structure, new SimpleFileVisitor<Path>() {
                @Override
                public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) throws IOException {
                    stream.putNextEntry(new ZipEntry(structure.relativize(file).toString()));
                    Files.copy(file, stream);
                    return FileVisitResult.CONTINUE;
                }
            });
        }
        return zip.toUri().toURL();
    }
}