diff options
Diffstat (limited to 'core/src/test/java/org/elasticsearch/index/query/SimpleQueryStringBuilderTests.java')
-rw-r--r-- | core/src/test/java/org/elasticsearch/index/query/SimpleQueryStringBuilderTests.java | 16 |
1 files changed, 12 insertions, 4 deletions
diff --git a/core/src/test/java/org/elasticsearch/index/query/SimpleQueryStringBuilderTests.java b/core/src/test/java/org/elasticsearch/index/query/SimpleQueryStringBuilderTests.java index 5e221748e2..e08221a168 100644 --- a/core/src/test/java/org/elasticsearch/index/query/SimpleQueryStringBuilderTests.java +++ b/core/src/test/java/org/elasticsearch/index/query/SimpleQueryStringBuilderTests.java @@ -47,7 +47,6 @@ import java.util.Set; import static org.hamcrest.Matchers.anyOf; import static org.hamcrest.Matchers.containsString; import static org.hamcrest.Matchers.equalTo; -import static org.hamcrest.Matchers.greaterThan; import static org.hamcrest.Matchers.instanceOf; import static org.hamcrest.Matchers.is; import static org.hamcrest.Matchers.notNullValue; @@ -244,9 +243,16 @@ public class SimpleQueryStringBuilderTests extends AbstractQueryTestCase<SimpleQ Map.Entry<String, Float> field = fieldsIterator.next(); assertTermOrBoostQuery(booleanClause.getQuery(), field.getKey(), queryBuilder.value(), field.getValue()); } - if (queryBuilder.minimumShouldMatch() != null && !boolQuery.isCoordDisabled()) { + /** + * TODO: + * Test disabled because we cannot check min should match consistently: + * https://github.com/elastic/elasticsearch/issues/23966 + * + if (queryBuilder.minimumShouldMatch() != null && !boolQuery.isCoordDisabled()) { assertThat(boolQuery.getMinimumNumberShouldMatch(), greaterThan(0)); - } + } + * + **/ } else if (queryBuilder.fields().size() == 1) { Map.Entry<String, Float> field = queryBuilder.fields().entrySet().iterator().next(); assertTermOrBoostQuery(query, field.getKey(), queryBuilder.value(), field.getValue()); @@ -331,6 +337,7 @@ public class SimpleQueryStringBuilderTests extends AbstractQueryTestCase<SimpleQ assertEquals(json, ".quote", parsed.quoteFieldSuffix()); } + @AwaitsFix(bugUrl = "Waiting on fix for minimumShouldMatch https://github.com/elastic/elasticsearch/issues/23966") public void testMinimumShouldMatch() throws IOException { QueryShardContext shardContext = createShardContext(); int numberOfTerms = randomIntBetween(1, 4); @@ -357,7 +364,8 @@ public class SimpleQueryStringBuilderTests extends AbstractQueryTestCase<SimpleQ assertThat(query, instanceOf(BooleanQuery.class)); BooleanQuery boolQuery = (BooleanQuery) query; int expectedMinimumShouldMatch = numberOfTerms * percent / 100; - if (numberOfTerms == 1 || simpleQueryStringBuilder.defaultOperator().equals(Operator.AND)) { + if (numberOfTerms == 1 + || simpleQueryStringBuilder.defaultOperator().equals(Operator.AND)) { expectedMinimumShouldMatch = 0; } assertEquals(expectedMinimumShouldMatch, boolQuery.getMinimumNumberShouldMatch()); |