summaryrefslogtreecommitdiff
path: root/core/src/test/java/org/elasticsearch/search
diff options
context:
space:
mode:
authorChristoph Büscher <christoph@elastic.co>2017-05-29 15:45:51 +0200
committerGitHub <noreply@github.com>2017-05-29 15:45:51 +0200
commit57410058124da8b3ed0ce402b3324105fbcd3523 (patch)
tree592984086645e614a0e18b3c3895243661999ad7 /core/src/test/java/org/elasticsearch/search
parent25516868fe6f9beae8f66aaf3aef777a27644ef8 (diff)
[Tests] Harden InternalExtendedStatsTests (#24934)
The order in which double values are added in Java can give different results, so in testing the sum and sumOfSquares we need to allow some delta for testing equality. The difference can be larger for large sum values, so we should account for this by making the delta in the assertion depend on the values magnitude. Closes #24931
Diffstat (limited to 'core/src/test/java/org/elasticsearch/search')
-rw-r--r--core/src/test/java/org/elasticsearch/search/aggregations/metrics/InternalExtendedStatsTests.java7
1 files changed, 5 insertions, 2 deletions
diff --git a/core/src/test/java/org/elasticsearch/search/aggregations/metrics/InternalExtendedStatsTests.java b/core/src/test/java/org/elasticsearch/search/aggregations/metrics/InternalExtendedStatsTests.java
index a6ccce6fbe..2ea386ebb2 100644
--- a/core/src/test/java/org/elasticsearch/search/aggregations/metrics/InternalExtendedStatsTests.java
+++ b/core/src/test/java/org/elasticsearch/search/aggregations/metrics/InternalExtendedStatsTests.java
@@ -79,10 +79,13 @@ public class InternalExtendedStatsTests extends InternalAggregationTestCase<Inte
}
assertEquals(sigma, reduced.getSigma(), 0);
assertEquals(expectedCount, reduced.getCount());
- assertEquals(expectedSum, reduced.getSum(), 1e-07);
+ // The order in which you add double values in java can give different results. The difference can
+ // be larger for large sum values, so we make the delta in the assertion depend on the values magnitude
+ assertEquals(expectedSum, reduced.getSum(), Math.abs(expectedSum) * 1e-12);
assertEquals(expectedMin, reduced.getMin(), 0d);
assertEquals(expectedMax, reduced.getMax(), 0d);
- assertEquals(expectedSumOfSquare, reduced.getSumOfSquares(), 1e-07);
+ // summing squared values, see reason for delta above
+ assertEquals(expectedSumOfSquare, reduced.getSumOfSquares(), expectedSumOfSquare * 1e-14);
}
@Override