Settings: Remove shared setting property (#24728)

Shared settings were added intially to allow the few common settings
names across aws plugins. However, in 6.0 these settings have been
removed. The last use was in netty, but since 6.0 also has the netty 3
modules removed, there is no longer a need for the shared property. This
commit removes the shared setting property.

1 files changed, 0 insertions, 19 deletions

diff --git a/core/src/test/java/org/elasticsearch/common/settings/SettingsModuleTests.java b/core/src/test/java/org/elasticsearch/common/settings/SettingsModuleTests.java
index 6da023aef2..f2d9016a09 100644
--- a/core/src/test/java/org/elasticsearch/common/settings/SettingsModuleTests.java
+++ b/core/src/test/java/org/elasticsearch/common/settings/SettingsModuleTests.java
@@ -207,23 +207,4 @@ public class SettingsModuleTests extends ModuleTestCase {
             assertEquals("unknown setting [index.query.bool.max_clause_count] did you mean [indices.query.bool.max_clause_count]?",
                 ex.getMessage());
     }
-
-    public void testRegisterShared() {
-        Property scope = randomFrom(Property.NodeScope, Property.IndexScope);
-        expectThrows(IllegalArgumentException.class, () ->
-            new SettingsModule(Settings.EMPTY,
-                Setting.simpleString("index.foo.bar", scope), Setting.simpleString("index.foo.bar", scope))
-        );
-        expectThrows(IllegalArgumentException.class, () ->
-            new SettingsModule(Settings.EMPTY,
-                Setting.simpleString("index.foo.bar", scope, Property.Shared), Setting.simpleString("index.foo.bar", scope))
-        );
-        expectThrows(IllegalArgumentException.class, () ->
-            new SettingsModule(Settings.EMPTY,
-                Setting.simpleString("index.foo.bar", scope), Setting.simpleString("index.foo.bar", scope, Property.Shared))
-        );
-        new SettingsModule(Settings.EMPTY,
-            Setting.simpleString("index.foo.bar", scope, Property.Shared),
-            Setting.simpleString("index.foo.bar", scope, Property.Shared));
-    }
 }