diff options
author | Nik Everett <nik9000@gmail.com> | 2016-04-19 12:31:28 -0400 |
---|---|---|
committer | Nik Everett <nik9000@gmail.com> | 2016-04-19 15:46:46 -0400 |
commit | 7d94cc99a75ccb89dd46ef560d4eb23a5c7b67af (patch) | |
tree | be5ee31ed3ee6e4f8864e548f9522325f966ec1b /core/src/main/java/org/elasticsearch/search/aggregations/bucket/range | |
parent | cd982ade99ce2db939b7ed9278ba199010641131 (diff) |
Remove more PROTOTYPEs from aggregations
Relates to #17085
Diffstat (limited to 'core/src/main/java/org/elasticsearch/search/aggregations/bucket/range')
2 files changed, 15 insertions, 20 deletions
diff --git a/core/src/main/java/org/elasticsearch/search/aggregations/bucket/range/geodistance/GeoDistanceAggregatorBuilder.java b/core/src/main/java/org/elasticsearch/search/aggregations/bucket/range/geodistance/GeoDistanceAggregatorBuilder.java index cadaab15b5..a72b4fd322 100644 --- a/core/src/main/java/org/elasticsearch/search/aggregations/bucket/range/geodistance/GeoDistanceAggregatorBuilder.java +++ b/core/src/main/java/org/elasticsearch/search/aggregations/bucket/range/geodistance/GeoDistanceAggregatorBuilder.java @@ -75,7 +75,7 @@ public class GeoDistanceAggregatorBuilder extends ValuesSourceAggregatorBuilder< int size = in.readVInt(); ranges = new ArrayList<>(size); for (int i = 0; i < size; i++) { - ranges.add(Range.PROTOTYPE.readFrom(in)); + ranges.add(new Range(in)); } keyed = in.readBoolean(); distanceType = GeoDistance.readFromStream(in); diff --git a/core/src/main/java/org/elasticsearch/search/aggregations/bucket/range/geodistance/GeoDistanceParser.java b/core/src/main/java/org/elasticsearch/search/aggregations/bucket/range/geodistance/GeoDistanceParser.java index bc4353d18b..ed6d6a67e2 100644 --- a/core/src/main/java/org/elasticsearch/search/aggregations/bucket/range/geodistance/GeoDistanceParser.java +++ b/core/src/main/java/org/elasticsearch/search/aggregations/bucket/range/geodistance/GeoDistanceParser.java @@ -54,13 +54,24 @@ public class GeoDistanceParser extends GeoPointValuesSourceParser { } public static class Range extends RangeAggregator.Range { - - static final Range PROTOTYPE = new Range(null, null, null); - public Range(String key, Double from, Double to) { super(key(key, from, to), from == null ? 0 : from, to); } + /** + * Read from a stream. + */ + public Range(StreamInput in) throws IOException { + super(in.readOptionalString(), in.readDouble(), in.readDouble()); + } + + @Override + public void writeTo(StreamOutput out) throws IOException { + out.writeOptionalString(key); + out.writeDouble(from); + out.writeDouble(to); + } + private static String key(String key, Double from, Double to) { if (key != null) { return key; @@ -71,22 +82,6 @@ public class GeoDistanceParser extends GeoPointValuesSourceParser { sb.append((to == null || Double.isInfinite(to)) ? "*" : to); return sb.toString(); } - - @Override - public Range readFrom(StreamInput in) throws IOException { - String key = in.readOptionalString(); - double from = in.readDouble(); - double to = in.readDouble(); - return new Range(key, from, to); - } - - @Override - public void writeTo(StreamOutput out) throws IOException { - out.writeOptionalString(key); - out.writeDouble(from); - out.writeDouble(to); - } - } @Override |