From c7cf88391f0bdae891f491c83ab96bfbedac9f97 Mon Sep 17 00:00:00 2001 From: Norris Lee Date: Tue, 24 Feb 2015 17:37:42 -0800 Subject: DRILL-2307: Detect DNS name resolution failure for better error messages --- contrib/native/client/src/clientlib/drillClientImpl.cpp | 4 ++++ contrib/native/client/src/include/drill/common.hpp | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) (limited to 'contrib/native/client/src') diff --git a/contrib/native/client/src/clientlib/drillClientImpl.cpp b/contrib/native/client/src/clientlib/drillClientImpl.cpp index d14119d3a..71f960e0f 100644 --- a/contrib/native/client/src/clientlib/drillClientImpl.cpp +++ b/contrib/native/client/src/clientlib/drillClientImpl.cpp @@ -141,6 +141,10 @@ connectionStatus_t DrillClientImpl::connect(const char* host, const char* port){ } }catch(std::exception e){ + // Handle case when the hostname cannot be resolved. "resolve" is hard-coded in boost asio resolver.resolve + if (!strcmp(e.what(), "resolve")) { + return handleConnError(CONN_HOSTNAME_RESOLUTION_ERROR, getMessage(ERR_CONN_EXCEPT, e.what())); + } return handleConnError(CONN_FAILURE, getMessage(ERR_CONN_EXCEPT, e.what())); } diff --git a/contrib/native/client/src/include/drill/common.hpp b/contrib/native/client/src/include/drill/common.hpp index dbfa6fec6..656069271 100644 --- a/contrib/native/client/src/include/drill/common.hpp +++ b/contrib/native/client/src/include/drill/common.hpp @@ -106,7 +106,8 @@ typedef enum{ CONN_HANDSHAKE_FAILED=2, CONN_INVALID_INPUT=3, CONN_ZOOKEEPER_ERROR=4, - CONN_HANDSHAKE_TIMEOUT=5 + CONN_HANDSHAKE_TIMEOUT=5, + CONN_HOSTNAME_RESOLUTION_ERROR=6 } connectionStatus_t; typedef enum{ -- cgit v1.2.3